Skip to content

add ecx.probe_candidate #113329

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 5, 2023
Merged

add ecx.probe_candidate #113329

merged 1 commit into from
Jul 5, 2023

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jul 4, 2023

Not yet changing the candidate source to an enum because that would be more involved, but this by itself should already be a significant improvement imo

r? @BoxyUwU

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jul 4, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 4, 2023

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@lcnr lcnr force-pushed the probe_candidate branch from 734b3c2 to 795c2ef Compare July 4, 2023 15:08
@BoxyUwU
Copy link
Member

BoxyUwU commented Jul 4, 2023

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jul 4, 2023

📌 Commit 795c2ef has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2023
@bors
Copy link
Collaborator

bors commented Jul 5, 2023

⌛ Testing commit 795c2ef with merge 9227ff2...

@bors
Copy link
Collaborator

bors commented Jul 5, 2023

☀️ Test successful - checks-actions
Approved by: BoxyUwU
Pushing 9227ff2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 5, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9227ff2): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.5% [3.2%, 3.8%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 653.897s -> 654.835s (0.14%)

@BoxyUwU
Copy link
Member

BoxyUwU commented Jul 5, 2023

I uhh think this can be closed now since it got merged lol?

@bors bors merged commit 9227ff2 into rust-lang:master Jul 5, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jul 5, 2023
@lcnr lcnr deleted the probe_candidate branch July 5, 2023 09:21
@lqd lqd mentioned this pull request May 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants