Skip to content

additional io::copy specializations #113493

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2023
Merged

additional io::copy specializations #113493

merged 1 commit into from
Jul 9, 2023

Conversation

the8472
Copy link
Member

@the8472 the8472 commented Jul 8, 2023

  • copying from &[u8] and VecDeque<u8>
  • copying to Vec<u8>

A user on reddit mentioned they saw a performance drop when copying from a slice.

@rustbot
Copy link
Collaborator

rustbot commented Jul 8, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 8, 2023
@rust-log-analyzer

This comment has been minimized.

# to view
@the8472
additional io::copy specializations
6f8ba51 
- copying from `&[u8]` and `VecDeque<u8>`
- copying to `Vec<u8>`
@the8472 the8472 force-pushed the spec-iocopy-slice branch from 37dc4a3 to 6f8ba51 Compare July 8, 2023 22:06
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 9, 2023

📌 Commit 6f8ba51 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 9, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 9, 2023
@matthiaskrgr
Rollup merge of rust-lang#113493 - the8472:spec-iocopy-slice, r=Mark-…
1fce13a 
…Simulacrum

additional io::copy specializations

- copying from `&[u8]` and `VecDeque<u8>`
- copying to `Vec<u8>`

A user on reddit [mentioned they saw a performance drop](https://www.reddit.com/r/rust/comments/14shv9f/comment/jr0bg6j/?context=3) when copying from a slice.
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 9, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 9, 2023
@bors
Auto merge of rust-lang#113508 - matthiaskrgr:rollup-xzrp4nt, r=matth…
a9eba8d 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#111618 (Always name the return place.)
 - rust-lang#113247 (Add Tests for native wasm exceptions)
 - rust-lang#113273 (Use String or Int to set the opt level)
 - rust-lang#113469 (Remove `default_free_fn` feature)
 - rust-lang#113493 (additional io::copy specializations)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 205ae16 into rust-lang:master Jul 9, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 9, 2023
@bczhc bczhc mentioned this pull request Sep 22, 2023
Merged
@PSeitz PSeitz mentioned this pull request Nov 3, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
5 participants
@the8472 @rustbot @rust-log-analyzer @Mark-Simulacrum @bors