Add even more GHA log groups #113514

jyn514 · 2023-07-09T22:20:33Z

This also adds a dynamic check that we don't emit nested groups, since GHA currently doesn't support them.

oli-obk · 2023-07-10T12:47:41Z

src/tools/build_helper/src/ci.rs

+        // https://github.com/actions/toolkit/issues/1001
+        assert!(
+            !GROUP_ACTIVE.swap(true, Ordering::Relaxed),
+            "nested groups are not supported by GHA!"
+        );


I should probably do this in ui_test, too

oli-obk · 2023-07-10T12:51:14Z

@bors r+ rollup

wow, logs look so accessible now

bors · 2023-07-10T12:51:17Z

📌 Commit 7064af0 has been approved by oli-obk

It is now in the queue for this repository.

Add even more GHA log groups This also adds a dynamic check that we don't emit nested groups, since GHA currently doesn't support them. r? `@oli-obk`

Add even more GHA log groups This also adds a dynamic check that we don't emit nested groups, since GHA currently doesn't support them. r? ``@oli-obk``

matthiaskrgr · 2023-07-10T22:56:22Z

@bors r-
#113554 (comment)

bors · 2023-07-12T16:49:09Z

☔ The latest upstream changes (presumably #113214) made this pull request unmergeable. Please resolve the merge conflicts.

jyn514 · 2023-07-13T06:06:15Z

@bors r=oli-obk rollup=iffy

bors · 2023-07-13T06:06:17Z

📌 Commit db2853fe97f9897a3374d0f367eed48db0520619 has been approved by oli-obk

It is now in the queue for this repository.

bors · 2023-07-14T03:00:16Z

☔ The latest upstream changes (presumably #113676) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2023-07-14T22:36:10Z

📌 Commit 3a0caed has been approved by oli-obk

It is now in the queue for this repository.

bors · 2023-07-14T23:06:00Z

⌛ Testing commit 3a0caed with merge 4888db91469c3e293a7ad1ba5ceae2649821da6c...

bors · 2023-07-15T00:54:13Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 4888db91469c3e293a7ad1ba5ceae2649821da6c to master...

bors · 2023-07-15T00:54:18Z

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

rust-timer · 2023-07-15T10:16:11Z

Finished benchmarking commit (4888db91469c3e293a7ad1ba5ceae2649821da6c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.0%	[0.8%, 3.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-3.7%, -1.6%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.3%	[1.6%, 4.9%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.3%	[1.6%, 4.9%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 657.64s -> 659.449s (0.28%)

jyn514 · 2023-07-15T13:09:02Z

try build got merged and this was tested before the tree was closed 😞 bef6ff6 https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Cannot.20get.20rust-dev-nightly.20from.20ci-artifacts.2Erust-lang.2Eorg

jyn514 · 2023-07-15T13:22:59Z

@bors retry #113713

bors · 2023-07-15T13:52:07Z

⌛ Testing commit 3a0caed with merge 4d6e426...

bors · 2023-07-15T15:39:47Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 4d6e426 to master...

rust-timer · 2023-07-15T16:57:30Z

Finished benchmarking commit (4d6e426): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.7%, 3.0%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-3.6%, -1.7%]	3
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 657.64s -> 657.725s (0.01%)

jyn514 · 2023-07-15T17:13:57Z

this doesn't affect how the compiler was built at all, the perf regression must be spurious.

pnkfelix · 2023-07-18T16:55:22Z

this doesn't affect how the compiler was built at all, the perf regression must be spurious.

I agree. Marking as triaged.

@rustbot label: +perf-regression-triaged

rustbot assigned oli-obk Jul 9, 2023

This comment has been minimized.

# to view

jyn514 force-pushed the more-gha-groups branch from 2c8b083 to 7064af0 Compare July 10, 2023 04:08

oli-obk reviewed Jul 10, 2023

View reviewed changes

oli-obk approved these changes Jul 10, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2023

matthiaskrgr mentioned this pull request Jul 10, 2023

Rollup of 5 pull requests #113552

Closed

matthiaskrgr mentioned this pull request Jul 10, 2023

Rollup of 5 pull requests #113554

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 10, 2023

jyn514 force-pushed the more-gha-groups branch from 7064af0 to db2853f Compare July 13, 2023 05:41

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 13, 2023

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 14, 2023

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 14, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 14, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 15, 2023

bors merged commit 4d6e426 into rust-lang:master Jul 15, 2023

rustbot added this to the 1.73.0 milestone Jul 15, 2023

This was referenced Jul 15, 2023

Unite bless environment variables under RUSTC_BLESS #113298

Merged

bootstrap: Clean up try_run #113643

Merged

rustbot added the perf-regression Performance regression. label Jul 15, 2023

jyn514 deleted the more-gha-groups branch July 15, 2023 17:13

This was referenced Jul 16, 2023

Don't require each rustc_interface tool to opt-in to parallel_compiler #113606

Merged

Rollup of 3 pull requests #113738

Merged

x test error_index_generator triggers 'nested groups are not supported by GHA' check #113798

Closed

rustbot added the perf-regression-triaged The performance regression has been triaged. label Jul 18, 2023

onur-ozkan mentioned this pull request Jul 25, 2023

Define CMAKE_SYSTEM_NAME on a cross build targeting DragonFly. #113996

Merged

matthiaskrgr mentioned this pull request Feb 22, 2024

LLVM ERROR Attribute 'align' exceed the max size 2^14 #121444

Closed

Add even more GHA log groups #113514

Add even more GHA log groups #113514

Uh oh!

Conversation

jyn514 commented Jul 9, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

oli-obk commented Jul 10, 2023

Uh oh!

bors commented Jul 10, 2023

Uh oh!

matthiaskrgr commented Jul 10, 2023

Uh oh!

bors commented Jul 12, 2023

Uh oh!

jyn514 commented Jul 13, 2023

Uh oh!

bors commented Jul 13, 2023

Uh oh!

bors commented Jul 14, 2023

Uh oh!

bors commented Jul 14, 2023

Uh oh!

bors commented Jul 14, 2023

Uh oh!

bors commented Jul 15, 2023

Uh oh!

bors commented Jul 15, 2023

Uh oh!

rust-timer commented Jul 15, 2023

Overall result: no relevant changes - no action needed

Uh oh!

jyn514 commented Jul 15, 2023

Uh oh!

jyn514 commented Jul 15, 2023

Uh oh!

bors commented Jul 15, 2023

Uh oh!

bors commented Jul 15, 2023

Uh oh!

rust-timer commented Jul 15, 2023

Overall result: ❌ regressions - ACTION NEEDED

Uh oh!

jyn514 commented Jul 15, 2023

Uh oh!

pnkfelix commented Jul 18, 2023

Uh oh!

Uh oh!