Skip to content

Ignore flaky clippy tests. #113621

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2023
Merged

Ignore flaky clippy tests. #113621

merged 1 commit into from
Jul 12, 2023

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jul 12, 2023

These tests are frequently failing due to an issue in ui_test. ui_test doesn't appear to have a blanket ignore instruction that I could find, so I just approximated it with ignoring both 32 and 64 bit.

Fixes #113585

@rustbot
Copy link
Collaborator

rustbot commented Jul 12, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 12, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 12, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@Noratrieb
Copy link
Member

@bors r+ p=100 rollup=never

@bors
Copy link
Collaborator

bors commented Jul 12, 2023

📌 Commit fb5efd7 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2023
@bors
Copy link
Collaborator

bors commented Jul 12, 2023

⌛ Testing commit fb5efd7 with merge 33a2c24...

@yoshuawuyts yoshuawuyts mentioned this pull request Jul 12, 2023
Closed
@bors
Copy link
Collaborator

bors commented Jul 12, 2023

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing 33a2c24 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Jul 12, 2023

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing 33a2c24 to master...

@bors bors added merged-by-bors This PR was explicitly merged by bors. labels Jul 12, 2023
@bors bors merged commit 33a2c24 into rust-lang:master Jul 12, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 12, 2023
@ehuss ehuss mentioned this pull request Jul 12, 2023
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (33a2c24): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.0% [0.6%, 1.2%] 7
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.0% [0.6%, 1.2%] 7

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.0% [-2.0%, -2.0%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.0% [-2.0%, -2.0%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 4.3% [3.6%, 5.3%] 6
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 4.3% [3.6%, 5.3%] 6

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 657.557s -> 658.224s (0.10%)

@rustbot rustbot added the perf-regression Performance regression. label Jul 13, 2023
@lqd
Copy link
Member

lqd commented Jul 13, 2023

Noise, this PR changes tests.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Jul 13, 2023
@ehuss ehuss added beta-nominated Nominated for backporting to the compiler in the beta channel. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Aug 3, 2023
@ehuss
Copy link
Contributor Author

ehuss commented Aug 3, 2023

@rust-lang/release Nominating this for beta since it frequently causes CI to fail. I'm suggesting backporting it to help avoid trouble during the release process.

@cuviper
Copy link
Member

cuviper commented Aug 12, 2023

We didn't look at nominations in our last release meeting, but this looks plenty safe for backport.
@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 12, 2023
@cuviper cuviper mentioned this pull request Aug 12, 2023
Merged
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 12, 2023
@cuviper cuviper removed this from the 1.73.0 milestone Aug 12, 2023
@cuviper cuviper added this to the 1.72.0 milestone Aug 12, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 12, 2023
@bors
Auto merge of rust-lang#114748 - cuviper:beta-next, r=cuviper
d1fa3e4 
[beta] backport

* Restrict linker version script of proc-macro crates to just its two symbols rust-lang#114470
* bootstrap: config: fix version comparison bug rust-lang#114440
* lint/ctypes: only try normalize rust-lang#113921
* Avoid tls access while iterating through mpsc thread entries rust-lang#113861
* Substitute types before checking inlining compatibility. rust-lang#113802
* Revert "fix: bug etc/bash_complettion -> src/etc/... to avoid copy error" rust-lang#113579
* lint/ctypes: fix () return type checks rust-lang#113457
* Rename and allow cast_ref_to_mut lint rust-lang#113422
* Ignore flaky clippy tests. rust-lang#113621

r? cuviper
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.

Spurious clippy CI failure
8 participants
@ehuss @rustbot @Noratrieb @bors @rust-timer @lqd @cuviper @Mark-Simulacrum