Skip to content

clean stage-specific artifacts using x clean --stage #114126

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2023
Merged

clean stage-specific artifacts using x clean --stage #114126

merged 2 commits into from
Jul 31, 2023

Conversation

onur-ozkan
Copy link
Member

fixes #109313

@rustbot
Copy link
Collaborator

rustbot commented Jul 27, 2023

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 27, 2023
@albertlarsan68
Copy link
Member

Thanks for the PR!
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 30, 2023

📌 Commit 0ea852f has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2023
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 30, 2023
@Dylan-DPC
Rollup merge of rust-lang#114126 - ozkanonur:stage-support-for-clean,…
71c17d7 
… r=albertlarsan68

clean stage-specific artifacts using `x clean --stage`

fixes rust-lang#109313
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 30, 2023
Closed
@matthiaskrgr
Copy link
Member

@bors r-
https://github.com/rust-lang-ci/rust/actions/runs/5707514313/job/15464267886#step:24:43815
#114261

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 30, 2023
@onur-ozkan
support --stage for x clean
2526863 
Signed-off-by: ozkanonur <work@onurozkan.dev>
@onur-ozkan
remove stage-specific artifacts when --stage is used
78326cd 
Signed-off-by: ozkanonur <work@onurozkan.dev>
@onur-ozkan onur-ozkan force-pushed the stage-support-for-clean branch from 0ea852f to 78326cd Compare July 30, 2023 20:13
@onur-ozkan
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 30, 2023

📌 Commit 78326cd has been approved by ozkanonur

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 30, 2023
@workingjubilee
Copy link
Member

@bors rollup=iffy

@bors
Copy link
Collaborator

bors commented Jul 31, 2023

⌛ Testing commit 78326cd with merge d9feb02...

@bors
Copy link
Collaborator

bors commented Jul 31, 2023

☀️ Test successful - checks-actions
Approved by: ozkanonur
Pushing d9feb02 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 31, 2023
@bors bors merged commit d9feb02 into rust-lang:master Jul 31, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 31, 2023
This was referenced Jul 31, 2023
Merged
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d9feb02): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.5% [0.5%, 0.5%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.5% [0.5%, 0.5%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.4% [1.4%, 1.4%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.2% [-3.5%, -3.0%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 653.113s -> 652.627s (-0.07%)

@onur-ozkan onur-ozkan deleted the stage-support-for-clean branch July 31, 2023 04:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@albertlarsan68 albertlarsan68

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

x clean --stage 1 silently does the wrong thing
7 participants
@onur-ozkan @rustbot @albertlarsan68 @bors @matthiaskrgr @workingjubilee @rust-timer