Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert "add tidy check that forbids issue ui test filenames" #114133

Merged

Conversation

workingjubilee
Copy link
Member

This reverts commit 13e2abf.

Reverting because an MCP was requested and it turned out there was a lack of a consensus on what to do in this area.

This reverts commit 13e2abf.

Reverting because an MCP was requested and it turned out there
was a lack of a consensus on what to do in this area.
@rustbot
Copy link
Collaborator

rustbot commented Jul 27, 2023

r? @clubby789

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 27, 2023
@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 27, 2023

📌 Commit 686b3de has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2023
@pnkfelix
Copy link
Member

(Thank you to both @workingjubilee and @jackh726 for following up here.)

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 27, 2023
…kingjubilee

Rollup of 4 pull requests

Successful merges:

 - rust-lang#97571 (Add documentation on v0 symbol mangling.)
 - rust-lang#114122 (tests/ui/hello_world/main.rs: Remove FIXME (rust-lang#62277))
 - rust-lang#114133 (Revert "add tidy check that forbids issue ui test filenames")
 - rust-lang#114139 (Make `--print` with path unstable)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b5f83a9 into rust-lang:master Jul 27, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 27, 2023
@RalfJung
Copy link
Member

Cc #113583 (since I was very confused when I failed to find this code in the source and I did check the backreferences of the original PR)

@workingjubilee workingjubilee deleted the revert-add-tidy-check-issue-12345 branch July 28, 2023 20:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants