llvm::mk_object_file to option type (fixes OS X crash) #1142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ying LLVM function can fail. Fixes a crash on OS X when rust has bad dylibs within eyeshot.
|
Thanks, integrated. |
|
Very nice. |
bjorn3
added a commit
to bjorn3/rust
that referenced
this pull request
Mar 5, 2021
It causes a miscompilation of lewton Fixes rust-lang#1142
coastalwhite
pushed a commit
to coastalwhite/rust
that referenced
this pull request
Aug 5, 2023
I'm working on `try_trait_v2` which will break this, so I'm going around removing uses from the rustc tree where I can.
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
* Subsection for intrinsics and unstable features * Updates for Rust feature support * Update link in "Undefined behavior"
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm::mk_object_file should really return an option, since the underlying LLVM function can fail. Fixes a crash on OS X when rust has bad dylibs within eyeshot.
Probably other functions throughout the llvm bindings should also have option types returned when they could potentially return null from LLVM -- but this is at least enough to fix a crash in which a "bad" dylib (i.e., one that LLVM can't parse) causes rustc to crash.