Skip to content

compiletest: Handle non-utf8 paths (fix FIXME) #114429

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Aug 3, 2023

Removes the last FIXME in the code for #9639 🎉 (which was closed 8 years ago)

Part of #44366 which is E-help-wanted.

(The other two PRs that does this are #114377 and #114427)

@rustbot
Copy link
Collaborator

rustbot commented Aug 3, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 3, 2023
@est31
Copy link
Member

est31 commented Aug 3, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 3, 2023

📌 Commit f15832f has been approved by est31

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 3, 2023
compiletest: Handle non-utf8 paths (fix FIXME)

Removes the last FIXME in the code for rust-lang#9639  🎉 (which was closed 8 years ago)

Part of rust-lang#44366 which is E-help-wanted.

(The other two PRs that does this are rust-lang#114377 and rust-lang#114427)
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 4, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#113534 (Forbid old-style `simd_shuffleN` intrinsics)
 - rust-lang#113999 (Specify macro is invalid in certain contexts)
 - rust-lang#114348 (Migrate GUI colors test to original CSS color format)
 - rust-lang#114373 (unix/kernel_copy.rs: copy_file_range_candidate allows empty output files)
 - rust-lang#114404 (Migrate GUI colors test to original CSS color format)
 - rust-lang#114409 (builtin impl confirmation wuhu)
 - rust-lang#114429 (compiletest: Handle non-utf8 paths (fix FIXME))
 - rust-lang#114431 (Enable tests on rustc_codegen_ssa)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 90d93c3 into rust-lang:master Aug 4, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 4, 2023
@Enselic Enselic deleted the compiletest-fix branch August 17, 2023 14:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants