Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Switch to LLD as default linker for loongarch64-unknown-none* #114717

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Switch to LLD as default linker for loongarch64-unknown-none* #114717

merged 1 commit into from
Aug 15, 2023

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Aug 11, 2023

The LLD already supports LoongArch, it's time to switch to LLD as default linker for loongarch64-unknown-none*.

@rustbot
Copy link
Collaborator

rustbot commented Aug 11, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 11, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 11, 2023

These commits modify compiler targets.
(See the Target Tier Policy.)

@b-naber
Copy link
Contributor

b-naber commented Aug 14, 2023

I think this requires an MCP.

@heiher
Copy link
Contributor Author

heiher commented Aug 14, 2023

Hello, @b-naber Thanks for your comments. Before this, a explicit linker argument is required for this target. And now the linker argument is just optional. I think this is not a compatibility-breaking change, and referring to previous similar changes, I didn't find a related MCP: #109721

@b-naber
Copy link
Contributor

b-naber commented Aug 15, 2023

Thanks for looking this up.

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 15, 2023

📌 Commit 815868d has been approved by b-naber

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2023
@bors
Copy link
Collaborator

bors commented Aug 15, 2023

⌛ Testing commit 815868d with merge fd9525a...

@bors
Copy link
Collaborator

bors commented Aug 15, 2023

☀️ Test successful - checks-actions
Approved by: b-naber
Pushing fd9525a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 15, 2023
@bors bors merged commit fd9525a into rust-lang:master Aug 15, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 15, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fd9525a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.5% [1.5%, 3.9%] 7
Regressions ❌
(secondary)
2.3% [2.3%, 2.3%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.5% [1.5%, 3.9%] 7

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.653s -> 632.523s (0.14%)
Artifact size: 346.73 MiB -> 346.66 MiB (-0.02%)

@heiher heiher deleted the rust-lld branch August 16, 2023 01:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants