Skip to content

TAITs do not constrain generic params #114742

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

compiler-errors
Copy link
Member

Fixes #108425

Not sure if I should rework those two failing tests. I guess tests/ui/type-alias-impl-trait/coherence.rs could just have the type parameter removed from it? IDK what tests/ui/type-alias-impl-trait/coherence_generalization.rs is even testing, though.

r? @aliemjay
cc @lcnr @oli-obk (when he's back from 🌴)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 11, 2023
Copy link
Member

@aliemjay aliemjay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after the nit

compiler-errors and others added 2 commits August 12, 2023 17:14
Co-authored-by: Ali MJ Al-Nasrawy <alimjalnasrawy@gmail.com>
@rust-cloud-vms rust-cloud-vms bot force-pushed the opaques-are-not-injective branch from 681395d to 5c95e77 Compare August 12, 2023 17:19
@compiler-errors
Copy link
Member Author

@bors r=aliemjay

@bors
Copy link
Collaborator

bors commented Aug 13, 2023

📌 Commit 5c95e77 has been approved by aliemjay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2023
@bors
Copy link
Collaborator

bors commented Aug 13, 2023

⌛ Testing commit 5c95e77 with merge e81522a...

@bors
Copy link
Collaborator

bors commented Aug 14, 2023

☀️ Test successful - checks-actions
Approved by: aliemjay
Pushing e81522a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 14, 2023
@bors bors merged commit e81522a into rust-lang:master Aug 14, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 14, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e81522a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.7% [3.7%, 3.7%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.2% [-3.5%, -2.9%] 2
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 633.873s -> 632.781s (-0.17%)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TAIT shouldn't constrain impl generics
5 participants