Skip to content

Select obligations before processing wf obligation in compare_method_predicate_entailment #114787

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

compiler-errors
Copy link
Member

We need to select obligations before processing the WF obligation for the IMPLIED_BOUNDS_ENTAILMENT lint, since it skips over type variables.

Fixes #114783

r? @jackh726

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 13, 2023
@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 13, 2023

📌 Commit b6b5a65 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2023
@bors
Copy link
Collaborator

bors commented Aug 14, 2023

⌛ Testing commit b6b5a65 with merge 3071e0a...

@bors
Copy link
Collaborator

bors commented Aug 14, 2023

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 3071e0a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 14, 2023
@bors bors merged commit 3071e0a into rust-lang:master Aug 14, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 14, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3071e0a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.4% [-0.4%, -0.4%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.2% [2.2%, 4.3%] 5
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.781s -> 633.194s (0.07%)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly ICE: 'no errors encountered even though delay_span_bug issued' and 'unresolved inference variable in outlives: ?8t'
5 participants