Rollup of 5 pull requests #115018
Merged
Rollup of 5 pull requests #115018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clearly the code path can be hit without the presence of a compiler bug. All it takes is mischief. See 71698. Ignore problematic directories instead of ICE:ing. `continue`ing is already done for problematic dirs in the code block above us.
…fects, r=lcnr Avoid side-effects from `try_coerce` when suggesting borrowing LHS of cast The name `try_coerce` is a bit misleading -- it has side-effects, so when it's used in diagnostics code, it sometimes causes spurious obligations to be registered which cause other errors to occur that really make no sense in context. Addendum: let's just rename `try_coerce` to `coerce` -- the `try_` part doesn't really add much, imo.
Fix UB in `std::sys::os::getenv()` Fixes rust-lang#114949. Reduced the loops to 1k iterations (100k was taking way too long), Miri no longer shows any UB. `@rustbot` label +A-process +C-bug +I-unsound +O-unix
…piler-errors Ignore unexpected incr-comp session dirs Clearly the code path can be hit without the presence of a compiler bug. All it takes is mischief. See rust-lang#71698. Ignore problematic directories instead of ICE:ing. `continue`ing is already done for problematic dirs in the code block above us. Closes rust-lang#71698. With this fix, the output is this instead of ICE: ``` $ cargo +stage1 new gz-ice && cd gz-ice $ cargo +stage1 build $ find target -type f -exec gzip {} \; $ cargo +stage1 run Created binary (application) `gz-ice` package Compiling gz-ice v0.1.0 (/tmp/gz-ice) Finished dev [unoptimized + debuginfo] target(s) in 0.13s gzip: target/debug/gz-ice has 1 other link -- unchanged gzip: target/debug/deps/gz_ice-de919414dd9926b9 has 1 other link -- unchanged Compiling gz-ice v0.1.0 (/tmp/gz-ice) warning: failed to garbage collect invalid incremental compilation session directory `/tmp/gz-ice/target/debug/incremental/gz_ice-23qx9z9j9vghe/s-gnwd8daity-kp10sj.lock.gz`: Not a directory (os error 20) warning: `gz-ice` (bin "gz-ice") generated 1 warning Finished dev [unoptimized + debuginfo] target(s) in 0.13s Running `target/debug/gz-ice` Hello, world! ```
…lor-34, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. This test needed more cleanup: first I removed duplication by using a function, then I merge similar rules which had the same values. r? `@notriddle`
…er-errors,JakobDegen custom_mir: change Call() terminator syntax to something more readable I find our current syntax very hard to read -- I cannot even remember the order of arguments, and having the "next block" *before* the actual function call is very counter-intuitive IMO. So I suggest we use `Call(ret_val = function(v), next_block)` instead. r? `@JakobDegen`
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 39e0749329 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (b6ab01a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 636.001s -> 637.108s (0.17%) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
try_coercewhen suggesting borrowing LHS of cast #114834 (Avoid side-effects fromtry_coercewhen suggesting borrowing LHS of cast)std::sys::os::getenv()#114968 (Fix UB instd::sys::os::getenv())r? @ghost
@rustbot modify labels: rollup
Create a similar rollup