Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrate GUI colors test to original CSS color format #115023

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

GuillaumeGomez
Copy link
Member

Follow-up of #111459.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 20, 2023
@notriddle
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 20, 2023

📌 Commit f2f999e has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2023
@bors
Copy link
Contributor

bors commented Aug 20, 2023

⌛ Testing commit f2f999e with merge 1e7d7facafebc9291cb7743b584d0794d98389ad...

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
test [ui] tests/ui/traits/impl-different-num-params.rs ... ok
test [ui] tests/ui/traits/impl-method-mismatch.rs ... ok
test [ui] tests/ui/traits/default-method/xc.rs ... ok
test [ui] tests/ui/traits/impl-for-module.rs ... ok
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
test [ui] tests/ui/traits/impl_trait_as_trait_return_position.rs ... ok
test [ui] tests/ui/traits/impl-2.rs ... ok
test [ui] tests/ui/traits/impl-of-supertrait-has-wrong-lifetime-parameters.rs ... ok
test [ui] tests/ui/traits/inductive-overflow/lifetime.rs ... ok
---
test [ui] tests/ui/traits/new-solver/temporary-ambiguity.rs ... ok
test [ui] tests/ui/traits/new-solver/structural-resolve-field.rs ... ok
test [ui] tests/ui/traits/new-solver/two-projection-param-candidates-are-ambiguous.rs ... ok
test [ui] tests/ui/traits/new-solver/unsafe-auto-trait-impl.rs ... ok
Session terminated, killing shell... ...killed.
test [ui] tests/ui/traits/new-solver/unevaluated-const-impl-trait-ref.rs#fails ... ok
time="2023-08-21T00:02:39Z" level=error msg="error waiting for container: unexpected EOF"
##[error]The operation was canceled.

@bors
Copy link
Contributor

bors commented Aug 21, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 21, 2023
@notriddle
Copy link
Contributor

@bors retry

Didn’t fail in the test that was updated.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2023
@bors
Copy link
Contributor

bors commented Aug 21, 2023

⌛ Testing commit f2f999e with merge 8a562f9...

@bors
Copy link
Contributor

bors commented Aug 21, 2023

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing 8a562f9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 21, 2023
@bors bors merged commit 8a562f9 into rust-lang:master Aug 21, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 21, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8a562f9): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.4% [1.4%, 1.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.7% [-3.7%, -3.7%] 1
All ❌✅ (primary) 1.4% [1.4%, 1.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 636.639s -> 635.684s (-0.15%)
Artifact size: 346.94 MiB -> 347.04 MiB (0.03%)

@GuillaumeGomez GuillaumeGomez deleted the migrate-gui-test-color-35 branch August 21, 2023 08:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants