Skip to content

Contents of reachable statics is reachable #115114

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2023
Merged

Contents of reachable statics is reachable #115114

merged 1 commit into from
Aug 23, 2023

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Aug 22, 2023

Fixes #115052.

@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 22, 2023
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 23, 2023

📌 Commit 0383131 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2023
@Dylan-DPC Dylan-DPC mentioned this pull request Aug 23, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 23, 2023
@bors
Auto merge of rust-lang#115126 - Dylan-DPC:rollup-g6w3qjd, r=Dylan-DPC
8105739 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#114930 (Automatically add OS labels to std PRs)
 - rust-lang#115053 (docs: Add example, reference link for `type` keyword.)
 - rust-lang#115092 (Add generics_of to smir)
 - rust-lang#115096 (Add regression test for not `memcpy`ing padding bytes)
 - rust-lang#115100 (Add support for `ptr::write`s for the `invalid_reference_casting` lint)
 - rust-lang#115114 (Contents of reachable statics is reachable)
 - rust-lang#115122 (Fix clippy lint for identical `if`/`else` contraining `?` expressions)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0a78123 into rust-lang:master Aug 23, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 23, 2023
@pnkfelix pnkfelix mentioned this pull request Aug 24, 2023
Open
@pnkfelix
Copy link
Member

beta-nominating for 1.73-beta: I am seeing evidence that this fixes issue #113104 , and linking errors are way less fun to deal with than ICE's.

@rustbot label: +beta-nominated

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 24, 2023
@tmiasko tmiasko deleted the 115052 branch August 24, 2023 17:10
@mmastrac mmastrac mentioned this pull request Aug 25, 2023
Closed
@apiraino
Copy link
Contributor

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 25, 2023
@madsmtm madsmtm mentioned this pull request Aug 27, 2023
Open
@cuviper cuviper mentioned this pull request Sep 1, 2023
Merged
@cuviper cuviper modified the milestones: 1.74.0, 1.73.0 Sep 1, 2023
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 1, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 1, 2023
@bors
Auto merge of rust-lang#115442 - cuviper:beta-next, r=cuviper
9f37cd4 
[beta] backports

- Contents of reachable statics is reachable rust-lang#115114
- Revert "Suggest using `Arc` on `!Send`/`!Sync` types" rust-lang#115311
- Stop emitting non-power-of-two vectors in (non-portable-SIMD) codegen rust-lang#115236
- Do not forget to pass DWARF fragment information to LLVM. rust-lang#115139
- rustdoc: use unicode-aware checks for redundant explicit link fastpath rust-lang#115070

r? cuviper
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@petrochenkov petrochenkov

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

internal compiler error: compiler/rustc_monomorphize/src/collector.rs:1038:9: no MIR available for DefId
8 participants
@tmiasko @rustbot @compiler-errors @bors @pnkfelix @apiraino @cuviper @petrochenkov