-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Disable MIR SROA optimization by default #115140
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
I think you'll need to re-bless the mir-opt tests to get CI to pass? |
They all passed without modification locally? 🤔 |
I get:
|
Turn off the MIR SROA optimization by default to prevent incorrect debuginfo generation and rustc ICEs caused by invalid LLVM IR being created. Related to rust-lang#115113
2871bab
to
298ec52
Compare
The issue was that I had |
@bors r+ rollup=never p=10 |
Is 1.72 going to be respun with this fix or will there be a followup 1.72.1? |
I believe this will get in for 1.72.0. The CI dist builds here are what get promoted, no further respin necessary. |
☀️ Test successful - checks-actions |
Is it expected that https://dev-static.rust-lang.org/dist/channel-rust-stable.toml still points to 6301e8c? |
@glandium yeah, rebuilding dev-static is a manual step that we haven't taken. Real stable will point at the tip of stable branch when it gets built later today. |
Turn off the MIR SROA optimization by default to prevent incorrect debuginfo generation and rustc ICEs caused by invalid LLVM IR being created.
Related to #115113
r? @cuviper
cc @saethlin