Skip to content

Include compiler flags when you break rust; #115158

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Aug 24, 2023

Closes #70661

r? @RalfJung who requested this feature :)

To make it available to other parts of the compiler.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 24, 2023
@rust-log-analyzer

This comment has been minimized.

@RalfJung
Copy link
Member

Looks like you'll have to normalize the exact flags away for the test.

This LGTM, but I'm not at all familiar with that code.
r? compiler

@rustbot rustbot assigned TaKO8Ki and unassigned RalfJung Aug 24, 2023
@compiler-errors
Copy link
Member

r? compiler-errors @bors r+

@bors
Copy link
Collaborator

bors commented Aug 24, 2023

📌 Commit d5e79f2 has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned TaKO8Ki Aug 24, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2023
@bors
Copy link
Collaborator

bors commented Aug 25, 2023

⌛ Testing commit d5e79f2 with merge a8b905c...

@bors
Copy link
Collaborator

bors commented Aug 25, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing a8b905c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 25, 2023
@bors bors merged commit a8b905c into rust-lang:master Aug 25, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 25, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a8b905c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.2% [2.0%, 2.4%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 633.115s -> 632.601s (-0.08%)
Artifact size: 315.71 MiB -> 315.72 MiB (0.00%)

@Enselic Enselic deleted the break-rust-args branch August 26, 2023 05:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"joke ICE" should dump flags
8 participants