Skip to content

Return ident for ExprField and PatField HIR nodes #115400

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2023
Merged

Return ident for ExprField and PatField HIR nodes #115400

merged 1 commit into from
Sep 1, 2023

Conversation

gurry
Copy link
Contributor

@gurry gurry commented Aug 31, 2023

Fixes #115264

@rustbot
Copy link
Collaborator

rustbot commented Aug 31, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 31, 2023
@rust-log-analyzer

This comment has been minimized.

# to view
@gurry gurry force-pushed the issue-115264-ice branch from 28ca4d9 to 2b7281c Compare August 31, 2023 10:28
compiler-errors
compiler-errors reviewed Aug 31, 2023
View reviewed changes
compiler-errors
compiler-errors reviewed Aug 31, 2023
View reviewed changes
@compiler-errors
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2023
@gurry
Copy link
Contributor Author

gurry commented Sep 1, 2023

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 1, 2023
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 1, 2023

📌 Commit 19574d2 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2023
@bors
Copy link
Collaborator

bors commented Sep 1, 2023

⌛ Testing commit 19574d2 with merge d3377034e17491eb3f672a871ddc1778d6acc04a...

@rust-log-analyzer
Copy link
Collaborator

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Sep 1, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 1, 2023
@gurry
Copy link
Contributor Author

gurry commented Sep 1, 2023

@bors try

@bors
Copy link
Collaborator

bors commented Sep 1, 2023

@gurry: 🔑 Insufficient privileges: not in try users

@compiler-errors
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2023
@bors
Copy link
Collaborator

bors commented Sep 1, 2023

⌛ Testing commit 19574d2 with merge 88d9b37...

@bors
Copy link
Collaborator

bors commented Sep 1, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 88d9b37 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 1, 2023
@bors bors merged commit 88d9b37 into rust-lang:master Sep 1, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 1, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (88d9b37): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.4% [0.4%, 0.4%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.7% [-4.4%, -0.9%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.6% [-4.4%, 0.4%] 3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.5% [0.5%, 0.5%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.5% [0.5%, 0.5%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 630.791s -> 631.304s (0.08%)
Artifact size: 316.37 MiB -> 316.42 MiB (0.02%)

@gurry gurry deleted the issue-115264-ice branch September 2, 2023 05:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.

ICE: no name for HirId
7 participants
@gurry @rustbot @rust-log-analyzer @compiler-errors @bors @rust-timer @TaKO8Ki