Skip to content

Don't forget to normalize the translated message #115513

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2023
Merged

Don't forget to normalize the translated message #115513

merged 1 commit into from
Sep 4, 2023

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Sep 3, 2023

This PR adds a missing call to normalize_whitespace after translating an label.

Fixes #115498

@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 3, 2023
@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 4, 2023

📌 Commit ec0975d has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2023
@bors
Copy link
Collaborator

bors commented Sep 4, 2023

⌛ Testing commit ec0975d with merge bf1e3f3...

@bors
Copy link
Collaborator

bors commented Sep 4, 2023

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing bf1e3f3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 4, 2023
@bors bors merged commit bf1e3f3 into rust-lang:master Sep 4, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 4, 2023
@Urgau Urgau deleted the normalize-msg-after-translate branch September 4, 2023 11:51
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bf1e3f3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.8% [-1.2%, -0.6%] 3
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 627.408s -> 627.22s (-0.03%)
Artifact size: 316.11 MiB -> 316.03 MiB (-0.02%)

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.

ice self.lines.iter().all(|r| !r.iter().any(|sc| sc.chr == \'\\t\'))
5 participants
@Urgau @rustbot @petrochenkov @bors @rust-timer