Allow library features to be marked internal as well #115623
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
compiler-errors
commented
Sep 6, 2023
| desc { "calculating the lib features defined in a crate" } | ||
| separate_provide_extern | ||
| arena_cache | ||
| } |
There was a problem hiding this comment.
I consolidated this into one query -- it's not necessarily a requirement of this PR to do so, so if that's not desirable, I could revert it.
There was a problem hiding this comment.
This is useful. Could you extract it in a standalone query? Or even a standalone PR, as there may be discussion on this PR.
This comment has been minimized.
This comment has been minimized.
|
Double-gating internal features was a mistake by itself, and now other unnecessary complexity is accumulating around that mistake. |
cjgillot
reviewed
Sep 7, 2023
| @@ -1027,7 +1030,7 @@ pub fn check_unused_or_stable_features(tcx: TyCtxt<'_>) { | |||
|
|
|||
| // We always collect the lib features declared in the current crate, even if there are | |||
| // no unknown features, because the collection also does feature attribute validation. | |||
| let local_defined_features = tcx.lib_features(()).to_vec(); | |||
| let local_defined_features = tcx.lib_features(rustc_hir::def_id::LOCAL_CRATE); | |||
| desc { "calculating the lib features defined in a crate" } | ||
| separate_provide_extern | ||
| arena_cache | ||
| } |
There was a problem hiding this comment.
This is useful. Could you extract it in a standalone query? Or even a standalone PR, as there may be discussion on this PR.
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Should all this method go in rustc_passes::stability::check_unused_or_stable_features?
cjgillot
added
S-waiting-on-author
|
I was thinking we could do this a lot simpler, and just trigger the lint for all features whose name ends in |
|
I kinda prefer the more general solution, but yeah, I'm happy doing it that way too. |
|
☔ The latest upstream changes (presumably #116199) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 21, 2023
…gillot Unify `defined_lib_features` and `lib_features` queries Extracts part of rust-lang#115623 (comment) I went with also introducing a `FeatureStability` enum, instead of using `Some(span)` to mean stable and `None` to mean unstable. r? `@cjgillot`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 5, 2023
…compiler-errors Add support for making lib features internal We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug. This extends that idea to lib features as well. It is an alternative to rust-lang#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal. Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang#115597.
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Dec 5, 2023
…compiler-errors Add support for making lib features internal We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug. This extends that idea to lib features as well. It is an alternative to rust-lang#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal. Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang#115597.
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Dec 5, 2023
…compiler-errors Add support for making lib features internal We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug. This extends that idea to lib features as well. It is an alternative to rust-lang#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal. Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang#115597.
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Dec 5, 2023
…compiler-errors Add support for making lib features internal We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug. This extends that idea to lib features as well. It is an alternative to rust-lang#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal. Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang#115597.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 6, 2023
Rollup merge of rust-lang#118123 - RalfJung:internal-lib-features, r=compiler-errors Add support for making lib features internal We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug. This extends that idea to lib features as well. It is an alternative to rust-lang#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal. Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang#115597.
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Dec 12, 2023
…errors Add support for making lib features internal We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug. This extends that idea to lib features as well. It is an alternative to rust-lang/rust#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal. Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang/rust#115597.
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
…errors Add support for making lib features internal We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug. This extends that idea to lib features as well. It is an alternative to rust-lang/rust#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal. Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang/rust#115597.
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
…errors Add support for making lib features internal We have the notion of an "internal" lang feature: a feature that is never intended to be stabilized, and using which can cause ICEs and other issues without that being considered a bug. This extends that idea to lib features as well. It is an alternative to rust-lang/rust#115623: instead of using an attribute to declare lib features internal, we simply do this based on the name. Everything ending in `_internals` or `_internal` is considered internal. Then we rename `core_intrinsics` to `core_intrinsics_internal`, which fixes rust-lang/rust#115597.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows
unstable(..., is_internal, ...)to mark a library feature as internal. Not sure if we should just have a different stability attribute, like#[internal(...)]with the same fields asunstable.Part of #115597.
This does no modification to the standard library yet.