Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Migrate GUI colors test to original CSS color format #115700

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Migrate GUI colors test to original CSS color format #115700

merged 1 commit into from
Sep 9, 2023

Conversation

GuillaumeGomez
Copy link
Member

Follow-up of #111459.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 9, 2023
@notriddle
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Sep 9, 2023

📌 Commit a0aa59c has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2023
@bors
Copy link
Contributor

bors commented Sep 9, 2023

⌛ Testing commit a0aa59c with merge 58b4ebc...

@bors
Copy link
Contributor

bors commented Sep 9, 2023

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing 58b4ebc to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 9, 2023
@bors bors merged commit 58b4ebc into rust-lang:master Sep 9, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 9, 2023
@GuillaumeGomez GuillaumeGomez deleted the migrate-gui-test-color-39 branch September 9, 2023 18:25
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (58b4ebc): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.3% [3.3%, 3.3%] 1
Regressions ❌
(secondary)		 3.1% [2.3%, 3.9%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.3% [3.3%, 3.3%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 630.442s -> 626.843s (-0.57%)
Artifact size: 317.88 MiB -> 317.92 MiB (0.01%)

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @notriddle @bors @rust-timer @rustbot