Skip to content

Update to LLVM 17.0.0 #115959

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2023
Merged

Update to LLVM 17.0.0 #115959

merged 1 commit into from
Sep 20, 2023

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Sep 19, 2023

This rebases our LLVM fork to 17.0.0.

Fixes #115681.

@nikic
Update to LLVM 17.0.0
531830c 
This rebases our LLVM fork to 17.0.0.

Fixes rust-lang#115681.
@rustbot
Copy link
Collaborator

rustbot commented Sep 19, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Sep 19, 2023

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 19, 2023
@nikic
Copy link
Contributor Author

nikic commented Sep 19, 2023

r? @cuviper

@rustbot rustbot assigned cuviper and unassigned davidtwco Sep 19, 2023
@cuviper
Copy link
Member

cuviper commented Sep 19, 2023

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Sep 19, 2023

📌 Commit 531830c has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2023
@cuviper
Copy link
Member

cuviper commented Sep 19, 2023

Nominating for 1.73-beta since #115681 is labeled as a critical beta regression.
(This would subsume the nomination of the 17-rc4 update in #115581.)

@rustbot label +beta-nominated

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 19, 2023
@bors
Copy link
Collaborator

bors commented Sep 19, 2023

⌛ Testing commit 531830c with merge 047fac0...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 19, 2023
@bors
Auto merge of rust-lang#115959 - nikic:update-llvm-13, r=cuviper
047fac0 
Update to LLVM 17.0.0

This rebases our LLVM fork to 17.0.0.

Fixes rust-lang#115681.
@rust-log-analyzer
Copy link
Collaborator

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Sep 19, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 19, 2023
@cuviper
Copy link
Member

cuviper commented Sep 19, 2023

Maybe that was a spurious problem with the remote-test-client?

2023-09-19T21:22:38.8241483Z ---- [ui] tests/ui/associated-consts/associated-const-public-impl.rs stdout ----
2023-09-19T21:22:38.8241966Z 
2023-09-19T21:22:38.8284492Z error: test run failed!
2023-09-19T21:22:38.8284790Z status: exit status: 101
2023-09-19T21:22:38.8285549Z command: RUST_TEST_THREADS="8" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/remote-test-client" "run" "0" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-consts/associated-const-public-impl/a"
2023-09-19T21:22:38.8286113Z --- stdout -------------------------------
2023-09-19T21:22:38.8286603Z uploaded "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-consts/associated-const-public-impl/a", waiting for result
2023-09-19T21:22:38.8286990Z ------------------------------------------
2023-09-19T21:22:38.8287253Z --- stderr -------------------------------
2023-09-19T21:22:38.8287897Z thread 'main' panicked at src/tools/remote-test-client/src/main.rs:310:9:
2023-09-19T21:22:38.8288279Z client.read_exact(&mut header) failed with Connection reset by peer (os error 104)
2023-09-19T21:22:38.8288647Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2023-09-19T21:22:38.8288972Z ------------------------------------------

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2023
@bors
Copy link
Collaborator

bors commented Sep 19, 2023

⌛ Testing commit 531830c with merge e2faa4a...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 19, 2023
@bors
Auto merge of rust-lang#115959 - nikic:update-llvm-13, r=cuviper
e2faa4a 
Update to LLVM 17.0.0

This rebases our LLVM fork to 17.0.0.

Fixes rust-lang#115681.
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
test [run-make] tests/run-make/rlib-format-packed-bundled-libs-3 ... ok
test [run-make] tests/run-make/rustdoc-output-path ... ok
test [run-make] tests/run-make/rustdoc-io-error ... ok
test [run-make] tests/run-make/rustdoc-map-file ... ok
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.


Session terminated, killing shell... ...killed.
##[error]The operation was canceled.
Cleaning up orphan processes

@bors
Copy link
Collaborator

bors commented Sep 20, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 20, 2023
@tmandry
Copy link
Member

tmandry commented Sep 20, 2023

Looks like a flake.

@bors r+ p=1

@bors

This comment was marked as outdated.

# to view
@bors

This comment was marked as outdated.

# to view
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2023
@tmandry
Copy link
Member

tmandry commented Sep 20, 2023

@bors r=cuviper
@bors retry

@bors

This comment was marked as outdated.

# to view
@bors
Copy link
Collaborator

bors commented Sep 20, 2023

📌 Commit 531830c has been approved by cuviper

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 20, 2023

⌛ Testing commit 531830c with merge 793d5ea...

@bors
Copy link
Collaborator

bors commented Sep 20, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 793d5ea to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 20, 2023
@bors bors merged commit 793d5ea into rust-lang:master Sep 20, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 20, 2023
@bors bors mentioned this pull request Sep 20, 2023
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (793d5ea): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.7% [0.6%, 0.7%] 2
Regressions ❌
(secondary)		 0.3% [0.3%, 0.3%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.7% [0.6%, 0.7%] 2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.4% [1.4%, 1.4%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.2% [-3.2%, -3.2%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.9% [-3.2%, 1.4%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.311s -> 630.757s (-0.25%)
Artifact size: 317.92 MiB -> 317.76 MiB (-0.05%)

@apiraino
Copy link
Contributor

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 21, 2023
@wesleywiser wesleywiser mentioned this pull request Sep 21, 2023
Merged
@cuviper cuviper mentioned this pull request Sep 22, 2023
Merged
@cuviper cuviper modified the milestones: 1.74.0, 1.73.0 Sep 22, 2023
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 22, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2023
@bors
Auto merge of rust-lang#116044 - cuviper:beta-next, r=cuviper
7c76587 
[beta] backports

-  Fix a pthread_t handle leak rust-lang#114696
-  MCP661: Move wasm32-wasi-preview1-threads target to Tier 2 rust-lang#115345
-  Don't modify libstd to dump rustc ICEs rust-lang#115627
-  Paper over an accidental regression rust-lang#115844
-  Update to LLVM 17.0.0 rust-lang#115959

r? cuviper
@MaxHearnden MaxHearnden mentioned this pull request Sep 22, 2023
Closed
@workingjubilee workingjubilee added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label May 26, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

Miscompile with -Copt-level=1 after update to LLVM 17
10 participants
@nikic @rustbot @cuviper @bors @rust-log-analyzer @tmandry @rust-timer @apiraino @davidtwco @workingjubilee