Skip to content

Rename MaybeUninit::write_slice #116385

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2024
Merged

Rename MaybeUninit::write_slice #116385

merged 1 commit into from
Feb 16, 2024

Conversation

kornelski
Copy link
Contributor

A step to push #79995 forward.

rust-lang/libs-team#122 also suggested to make them inherent methods, but they can't be — they'd conflict with slice's regular methods.

@rustbot
Copy link
Collaborator

rustbot commented Oct 3, 2023

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 3, 2023
@bors
Copy link
Collaborator

bors commented Nov 9, 2023

☔ The latest upstream changes (presumably #117736) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC Dylan-DPC added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2023
@joshtriplett
Copy link
Member

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Feb 11, 2024
@rustbot rustbot assigned Amanieu and unassigned joshtriplett Feb 11, 2024
@Amanieu
Copy link
Member

Amanieu commented Feb 16, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 16, 2024

📌 Commit da3db9a has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 16, 2024
@bors
Copy link
Collaborator

bors commented Feb 16, 2024

⌛ Testing commit da3db9a with merge ae9d7b0...

@bors
Copy link
Collaborator

bors commented Feb 16, 2024

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing ae9d7b0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 16, 2024
@bors bors merged commit ae9d7b0 into rust-lang:master Feb 16, 2024
@rustbot rustbot added this to the 1.78.0 milestone Feb 16, 2024
@bors bors mentioned this pull request Feb 16, 2024
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ae9d7b0): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.5% [0.5%, 0.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.4% [-0.4%, -0.4%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.7% [-3.7%, -3.7%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.7% [-3.7%, -3.7%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 639.642s -> 638.61s (-0.16%)
Artifact size: 306.35 MiB -> 306.35 MiB (0.00%)

@kornelski kornelski deleted the maybe-rename branch February 16, 2024 18:15
@beepster4096 beepster4096 mentioned this pull request Feb 16, 2024
Open
5 tasks
dennis-hamester added a commit to dennis-hamester/aldrin that referenced this pull request Apr 2, 2024
@dennis-hamester
core: fuzz: MaybeUninit::write_slice was renamed to copy_from_slice
3376c3c 
See rust-lang/rust#116385
ileixe added a commit to ileixe/owned-buf that referenced this pull request Sep 10, 2024
@ileixe
Change write_slice() to copy_from_slice()
eddd29f 
To follow API update[1], change MaybeUninit::write_slice() to
copy_from_slice().

[1]: rust-lang/rust#116385
@ileixe ileixe mentioned this pull request Sep 10, 2024
Open
@cod10129 cod10129 mentioned this pull request Nov 20, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
7 participants
@kornelski @rustbot @bors @joshtriplett @Amanieu @rust-timer @Dylan-DPC