Skip to content

Actually force a / in the path for ext crates #11639

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 19, 2014

Conversation

sfackler
Copy link
Member

If the library is in the working directory, its path won't have a "/"
which will cause dlopen to search /usr/lib etc. It turns out that Path
auto-normalizes during joins so Path::new(".").join(path) is actually a
no-op.

@alexcrichton
Copy link
Member

If you need to force an absolute path, would os::absolute_path be better to use?

If the library is in the working directory, its path won't have a "/"
which will cause dlopen to search /usr/lib etc. It turns out that Path
auto-normalizes during joins so Path::new(".").join(path) is actually a
no-op.
@sfackler
Copy link
Member Author

Oh, that's where that lives! I was looking for it on Path itself. Updated.

bors added a commit that referenced this pull request Jan 19, 2014
If the library is in the working directory, its path won't have a "/"
which will cause dlopen to search /usr/lib etc. It turns out that Path
auto-normalizes during joins so Path::new(".").join(path) is actually a
no-op.
@bors bors closed this Jan 19, 2014
@bors bors merged commit 1e20960 into rust-lang:master Jan 19, 2014
@sfackler sfackler deleted the macro-crate-path branch May 15, 2014 05:03
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 21, 2023
[`into_iter_without_iter`]: walk up deref impl chain to find `iter` methods

Fixes rust-lang#11635

changelog: [`into_iter_without_iter`]: walk up deref impl chain to find `iter` methods
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants