Skip to content

rustdoc: rename issue-\d+.rs tests to have meaningful names (part 3) #116824

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 17, 2023
Merged

rustdoc: rename issue-\d+.rs tests to have meaningful names (part 3) #116824

merged 5 commits into from
Oct 17, 2023

Conversation

notriddle
Copy link
Contributor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 16, 2023
fmease
fmease approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@fmease fmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I have some nitpicks you can address if you agree with them otherwise don't ^^.
Then, r=me.

tests/rustdoc/doc-hidden-extern-trait-impl-29584.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be moved to inline_cross/.

tests/rustdoc/duplicate-anchors-32890.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think disambiguate-anchors-32890 would be a better fit since there aren't any duplicate anchors (anymore).

tests/rustdoc/duplicate-anchors-header-29449.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here: duplicate → disambiguate.

tests/rustdoc/ice-assoc-const-for-primitive-31808.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(preexisting) This feels more like a rustdoc-ui/ test to me

@fmease
Copy link
Member

fmease commented Oct 17, 2023

@bors rollup

@notriddle
Copy link
Contributor Author

@bors r=fmease

@bors
Copy link
Collaborator

bors commented Oct 17, 2023

📌 Commit c0b6a5d has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2023
@bors
Copy link
Collaborator

bors commented Oct 17, 2023

⌛ Testing commit c0b6a5d with merge ddef56d...

@bors
Copy link
Collaborator

bors commented Oct 17, 2023

☀️ Test successful - checks-actions
Approved by: fmease
Pushing ddef56d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 17, 2023
@bors bors merged commit ddef56d into rust-lang:master Oct 17, 2023
@rustbot rustbot added this to the 1.75.0 milestone Oct 17, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ddef56d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.0% [-1.1%, -1.0%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.0% [-1.1%, -1.0%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 625.939s -> 626.612s (0.11%)
Artifact size: 305.58 MiB -> 305.59 MiB (0.00%)

@Veykril Veykril mentioned this pull request Oct 17, 2023
Merged
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request Oct 17, 2023
@bors-ferrocene @a1phyr
@ColinFinck @ijackson @joshlf @fmease @tgross35 @EvanMerlock @joboet @RalfJung @DaniPopes @Mark-Simulacrum @onur-ozkan @nnethercote @the8472 @sthibaul @reez12g @Kobzol
Merge #54
4d5dcf2 
54: Pull upstream master 2023 10 17 r=pietroalbini a=Veykril

* rust-lang/rust#116196
* rust-lang/rust#116824
* rust-lang/rust#116822
* rust-lang/rust#116477
* rust-lang/rust#116826
* rust-lang/rust#116820
  * rust-lang/rust#116811
  * rust-lang/rust#116808
  * rust-lang/rust#116805
  * rust-lang/rust#116800
  * rust-lang/rust#116798
  * rust-lang/rust#116754
* rust-lang/rust#114370
* rust-lang/rust#116804
  * rust-lang/rust#116802
  * rust-lang/rust#116790
  * rust-lang/rust#116786
  * rust-lang/rust#116709
  * rust-lang/rust#116430
  * rust-lang/rust#116257
  * rust-lang/rust#114157
* rust-lang/rust#116731
* rust-lang/rust#116550
* rust-lang/rust#114330
* rust-lang/rust#116724
* rust-lang/rust#116782
  * rust-lang/rust#116776
  * rust-lang/rust#115955
  * rust-lang/rust#115196
* rust-lang/rust#116775
* rust-lang/rust#114589
* rust-lang/rust#113747
* rust-lang/rust#116772
  * rust-lang/rust#116771
  * rust-lang/rust#116760
  * rust-lang/rust#116755
  * rust-lang/rust#116732
  * rust-lang/rust#116522
  * rust-lang/rust#116341
  * rust-lang/rust#116172
* rust-lang/rust#110604
* rust-lang/rust#110729
* rust-lang/rust#116527
* rust-lang/rust#116688
* rust-lang/rust#116757
  * rust-lang/rust#116753
  * rust-lang/rust#116748
  * rust-lang/rust#116741
  * rust-lang/rust#116594
* rust-lang/rust#116691
* rust-lang/rust#116643
* rust-lang/rust#116683
* rust-lang/rust#116635
* rust-lang/rust#115515
* rust-lang/rust#116742
  * rust-lang/rust#116661
  * rust-lang/rust#116576
  * rust-lang/rust#116540
* rust-lang/rust#116352
* rust-lang/rust#116737
  * rust-lang/rust#116730
  * rust-lang/rust#116723
  * rust-lang/rust#116715
  * rust-lang/rust#116603
  * rust-lang/rust#116591
  * rust-lang/rust#115439
* rust-lang/rust#116264
* rust-lang/rust#116727
  * rust-lang/rust#116704
  * rust-lang/rust#116696
  * rust-lang/rust#116695
  * rust-lang/rust#116644
  * rust-lang/rust#116630
* rust-lang/rust#116728
  * rust-lang/rust#116689
  * rust-lang/rust#116679
  * rust-lang/rust#116618
  * rust-lang/rust#116577
  * rust-lang/rust#115653
* rust-lang/rust#116702
* rust-lang/rust#116015
* rust-lang/rust#115822
* rust-lang/rust#116407
* rust-lang/rust#115719
* rust-lang/rust#115524
* rust-lang/rust#116705
* rust-lang/rust#116645
* rust-lang/rust#116233
* rust-lang/rust#115108
* rust-lang/rust#116670
* rust-lang/rust#116676
* rust-lang/rust#116666



Co-authored-by: Benoît du Garreau <bdgdlm@outlook.com>
Co-authored-by: Colin Finck <colin@reactos.org>
Co-authored-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Co-authored-by: Joshua Liebow-Feeser <joshlf@users.noreply.github.com>
Co-authored-by: León Orell Valerian Liehr <me@fmease.dev>
Co-authored-by: Trevor Gross <tmgross@umich.edu>
Co-authored-by: Evan Merlock <evan@merlock.dev>
Co-authored-by: joboet <jonasboettiger@icloud.com>
Co-authored-by: Ralf Jung <post@ralfj.de>
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
Co-authored-by: onur-ozkan <work@onurozkan.dev>
Co-authored-by: Nicholas Nethercote <n.nethercote@gmail.com>
Co-authored-by: The 8472 <git@infinite-source.de>
Co-authored-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Co-authored-by: reez12g <reez12g@gmail.com>
Co-authored-by: Jakub Beránek <berykubik@gmail.com>
@notriddle notriddle mentioned this pull request Nov 20, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2023
@bors
Auto merge of rust-lang#118105 - notriddle:master, r=fmease
eab8c7d 
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 4)

Follow up

* rust-lang#116214
* rust-lang#116432
* rust-lang#116824
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Nov 25, 2023
@bors
Auto merge of #118105 - notriddle:master, r=fmease
72e48ac 
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 4)

Follow up

* rust-lang/rust#116214
* rust-lang/rust#116432
* rust-lang/rust#116824
@notriddle notriddle mentioned this pull request Jan 3, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2024
@bors
Auto merge of rust-lang#119561 - notriddle:master, r=fmease
d8bd7e8 
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 5)

Follow up

* rust-lang#116214
* rust-lang#116432
* rust-lang#116824
* rust-lang#118105
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 14, 2024
@GuillaumeGomez
Rollup merge of rust-lang#119561 - notriddle:master, r=fmease
8914ca7 
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 5)

Follow up

* rust-lang#116214
* rust-lang#116432
* rust-lang#116824
* rust-lang#118105
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2024
@rust-timer
Unrolled build for rust-lang#119561
428e71b 
Rollup merge of rust-lang#119561 - notriddle:master, r=fmease

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 5)

Follow up

* rust-lang#116214
* rust-lang#116432
* rust-lang#116824
* rust-lang#118105
@notriddle notriddle mentioned this pull request Apr 6, 2024
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 16, 2024
@GuillaumeGomez
Rollup merge of rust-lang#123574 - notriddle:notriddle/issue-d, r=fmease
e7c13c3 
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 6)

Follow up

* rust-lang#116214
* rust-lang#116432
* rust-lang#116824
* rust-lang#118105
* rust-lang#119561
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 16, 2024
@rust-timer
Unrolled build for rust-lang#123574
aabe53b 
Rollup merge of rust-lang#123574 - notriddle:notriddle/issue-d, r=fmease

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 6)

Follow up

* rust-lang#116214
* rust-lang#116432
* rust-lang#116824
* rust-lang#118105
* rust-lang#119561
@notriddle notriddle mentioned this pull request May 21, 2024
Merged
fmease added a commit to fmease/rust that referenced this pull request May 22, 2024
@fmease
Rollup merge of rust-lang#125382 - notriddle:notriddle/issue-d, r=fmease
d98c470 
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 7)

Follow up

* rust-lang#116214
* rust-lang#116432
* rust-lang#116824
* rust-lang#118105
* rust-lang#119561
* rust-lang#123574

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 22, 2024
@rust-timer
Unrolled build for rust-lang#125382
5a12e86 
Rollup merge of rust-lang#125382 - notriddle:notriddle/issue-d, r=fmease

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 7)

Follow up

* rust-lang#116214
* rust-lang#116432
* rust-lang#116824
* rust-lang#118105
* rust-lang#119561
* rust-lang#123574

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request May 23, 2024
@fmease
Rollup merge of #125382 - notriddle:notriddle/issue-d, r=fmease
62642ca 
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 7)

Follow up

* rust-lang/rust#116214
* rust-lang/rust#116432
* rust-lang/rust#116824
* rust-lang/rust#118105
* rust-lang/rust#119561
* rust-lang/rust#123574

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
@notriddle notriddle mentioned this pull request Jul 13, 2024
Merged
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 13, 2024
@jhpratt
Rollup merge of rust-lang#127671 - notriddle:notriddle/issue-d, r=Mar…
6e18eaf 
…k-Simulacrum

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 8)

Follow up

* rust-lang#116214
* rust-lang#116432
* rust-lang#116824
* rust-lang#118105
* rust-lang#119561
* rust-lang#123574
* rust-lang#125382

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jul 14, 2024
@workingjubilee
Rollup merge of rust-lang#127671 - notriddle:notriddle/issue-d, r=Mar…
6a3566c 
…k-Simulacrum

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 8)

Follow up

* rust-lang#116214
* rust-lang#116432
* rust-lang#116824
* rust-lang#118105
* rust-lang#119561
* rust-lang#123574
* rust-lang#125382

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 14, 2024
@rust-timer
Unrolled build for rust-lang#127671
668b456 
Rollup merge of rust-lang#127671 - notriddle:notriddle/issue-d, r=Mark-Simulacrum

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 8)

Follow up

* rust-lang#116214
* rust-lang#116432
* rust-lang#116824
* rust-lang#118105
* rust-lang#119561
* rust-lang#123574
* rust-lang#125382

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Jul 16, 2024
@workingjubilee
Rollup merge of #127671 - notriddle:notriddle/issue-d, r=Mark-Simulacrum
c993d7b 
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 8)

Follow up

* rust-lang/rust#116214
* rust-lang/rust#116432
* rust-lang/rust#116824
* rust-lang/rust#118105
* rust-lang/rust#119561
* rust-lang/rust#123574
* rust-lang/rust#125382

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
@notriddle notriddle mentioned this pull request Sep 12, 2024
Merged
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 13, 2024
@Zalathar
Rollup merge of rust-lang#130287 - notriddle:notriddle/issue-d, r=jie…
1c23c8b 
…youxu

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 9)

Follow up

* rust-lang#116214
* rust-lang#116432
* rust-lang#116824
* rust-lang#118105
* rust-lang#119561
* rust-lang#123574
* rust-lang#125382
* rust-lang#127671

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 13, 2024
@rust-timer
Unrolled build for rust-lang#130287
ef74cd8 
Rollup merge of rust-lang#130287 - notriddle:notriddle/issue-d, r=jieyouxu

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 9)

Follow up

* rust-lang#116214
* rust-lang#116432
* rust-lang#116824
* rust-lang#118105
* rust-lang#119561
* rust-lang#123574
* rust-lang#125382
* rust-lang#127671

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Sep 14, 2024
@Zalathar
Rollup merge of #130287 - notriddle:notriddle/issue-d, r=jieyouxu
144f401 
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 9)

Follow up

* rust-lang/rust#116214
* rust-lang/rust#116432
* rust-lang/rust#116824
* rust-lang/rust#118105
* rust-lang/rust#119561
* rust-lang/rust#123574
* rust-lang/rust#125382
* rust-lang/rust#127671

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fmease fmease fmease approved these changes

Assignees

@fmease fmease

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.75.0
Development

Successfully merging this pull request may close these issues.
5 participants
@notriddle @fmease @bors @rust-timer @rustbot