Skip to content

Rollup of 5 pull requests #116901

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 10 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

compiler-errors and others added 10 commits October 12, 2023 14:00
…lint, r=lcnr

Bump `COINDUCTIVE_OVERLAP_IN_COHERENCE` to deny + warn in deps

1.73 is the first place this shows up in stable (recall that there was only 1 regression), so let's bump this to deny on nightly.

r? lcnr
…=lcnr

Don't ICE when encountering unresolved regions in `fully_resolve`

We can encounter unresolved regions due to unconstrained impl lifetime arguments because `collect_return_position_impl_trait_in_trait_tys` runs before WF actually checks that the impl is well-formed.

Fixes rust-lang#116525
Avoid having `rustc_smir` depend on `rustc_interface` or `rustc_driver`

This is done by moving all the logic into a macro that performs the entire "run" operation in one go.

This makes rust-lang#116806 obsolete

as a follow up we should make the macro usable without manually having to write

```rust
#[macro_use]
extern crate rustc_smir;
extern crate stable_mir;
extern crate rustc_driver;
extern crate rustc_interface;
use rustc_smir::rustc_internal;
```

in every crate that uses the macro.

r? `@spastorino`
Change my name in mailmap

I changed some things about my distro (my GPG key, along with the git username). This PR sets my committer name as `blyxyas` for those commits so that it is the same as my reviewer name in `thanks`.
Only check in a single place if a pass is enabled.

Fixes rust-lang#116294
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 18, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Oct 18, 2023

📌 Commit a76ab3e has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2023
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-15 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_dc38a058-8792-4229-8d5a-1614079e6def
GITHUB_EVENT_NAME=pull_request
GITHUB_EVENT_PATH=/home/runner/work/_temp/_github_workflow/event.json
GITHUB_GRAPHQL_URL=https://api.github.com/graphql
GITHUB_HEAD_REF=rollup-pz0bv2h
GITHUB_JOB=pr
GITHUB_PATH=/home/runner/work/_temp/_runner_file_commands/add_path_dc38a058-8792-4229-8d5a-1614079e6def
GITHUB_REF=refs/pull/116901/merge
GITHUB_REF_NAME=116901/merge
GITHUB_REF_PROTECTED=false
---

+ warning: the feature `async_fn_in_trait` has been stable since 1.75.0-nightly and no longer requires an attribute to enable
+   --> $DIR/unconstrained-impl-region.rs:3:12
+    |
+ LL | #![feature(async_fn_in_trait)]
+    |
+    = note: `#[warn(stable_features)]` on by default
+ 
+ 
1 error[E0207]: the lifetime parameter `'a` is not constrained by the impl trait, self type, or predicates
3    |


4 LL | impl<'a> Actor for () {
5    |      ^^ unconstrained lifetime parameter
- error: aborting due to previous error
+ error: aborting due to previous error; 1 warning emitted
8 
9 For more information about this error, try `rustc --explain E0207`.
---
--- stderr -------------------------------
warning: the feature `async_fn_in_trait` has been stable since 1.75.0-nightly and no longer requires an attribute to enable
##[warning]  --> /checkout/tests/ui/async-await/in-trait/unconstrained-impl-region.rs:3:12
   |
LL | #![feature(async_fn_in_trait)]
   |
   = note: `#[warn(stable_features)]` on by default


error[E0207]: the lifetime parameter `'a` is not constrained by the impl trait, self type, or predicates
   |
   |
LL | impl<'a> Actor for () {
   |      ^^ unconstrained lifetime parameter
error: aborting due to previous error; 1 warning emitted

For more information about this error, try `rustc --explain E0207`.
------------------------------------------

@matthiaskrgr matthiaskrgr deleted the rollup-pz0bv2h branch March 16, 2024 18:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants