Run tests in CI for aarch64-apple-darwin #117454

shepmaster · 2023-10-31T15:13:51Z

r? @ghost

shepmaster · 2023-10-31T15:14:15Z

@bors try

bors · 2023-10-31T15:15:26Z

⌛ Trying commit bf07b27 with merge 7655317...

…r=<try> Run tests in CI for aarch64-apple-darwin r? `@ghost`

bors · 2023-10-31T15:46:43Z

💔 Test failed - checks-actions

shepmaster · 2023-10-31T19:49:01Z

@bors try

bors · 2023-10-31T19:50:10Z

⌛ Trying commit 7a2ab46 with merge 223ccde...

…r=<try> Run tests in CI for aarch64-apple-darwin r? `@ghost`

bors · 2023-10-31T20:23:28Z

💔 Test failed - checks-actions

shepmaster · 2023-10-31T20:33:19Z

@bors try

bors · 2023-10-31T20:34:30Z

⌛ Trying commit 83d2dd2 with merge 2e94d63...

…r=<try> Run tests in CI for aarch64-apple-darwin r? `@ghost`

bors · 2023-10-31T20:35:27Z

💔 Test failed - checks-actions

shepmaster · 2023-10-31T20:39:56Z

@bors try

bors · 2023-10-31T20:41:06Z

⌛ Trying commit 4e9c7b8 with merge d98697a...

…r=<try> Run tests in CI for aarch64-apple-darwin r? `@ghost`

bors · 2023-10-31T21:16:43Z

☀️ Try build successful - checks-actions
Build commit: d98697a (d98697a931dea7a491f76a93555f95dad27cb356)

shepmaster · 2023-11-08T13:36:05Z

This should be ready to go now!

r? @Mark-Simulacrum

shepmaster · 2023-11-08T13:37:22Z

/cc @GuillaumeGomez as I'm touching the test you originally added.

tests/rustdoc-ui/issues/issue-107918.rs

GuillaumeGomez · 2023-11-08T13:39:15Z

/cc @GuillaumeGomez as I'm touching the test you originally added.

Thanks, much appreciated! :)

Due to incorrect CI configuration, this test was not being run on macOS. aarch64-apple-darwin will start running it, so we correct the configuration.

The GitHub Actions image has this preinstalled for x86_64 but not M1.

GuillaumeGomez

rustdoc test changes look good to me!

GuillaumeGomez · 2023-11-08T13:57:09Z

Let's set a reviewer from the infra team now.

r? @onur-ozkan

onur-ozkan

Changes looks good to me other than 1 question

src/ci/scripts/install-tidy.sh

onur-ozkan · 2023-11-08T15:55:11Z

I don't know when you want to ship this so I leave it to you. Feel free to r=GuillaumeGomez,me.

shepmaster · 2023-11-08T17:48:15Z

@bors r=GuillaumeGomez,onur-ozkan

bors · 2023-11-08T17:48:18Z

📌 Commit 6909992 has been approved by GuillaumeGomez,onur-ozkan

It is now in the queue for this repository.

bors · 2023-11-08T22:40:14Z

⌛ Testing commit 6909992 with merge 57fb1e6...

bors · 2023-11-09T00:37:54Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez,onur-ozkan
Pushing 57fb1e6 to master...

rust-timer · 2023-11-09T06:05:08Z

Finished benchmarking commit (57fb1e6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Warning ⚠: The following benchmark(s) failed to build:

exa-0.10.1
diesel-1.4.8

cc @rust-lang/wg-compiler-performance

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.4%, 1.2%]	7
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-0.8%, -0.4%]	2
Improvements ✅ (secondary)	-3.8%	[-3.8%, -3.8%]	1
All ❌✅ (primary)	0.4%	[-0.8%, 1.2%]	9

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.6%, 0.6%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.6%, 0.6%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 663.159s -> 662.945s (-0.03%)
Artifact size: 308.75 MiB -> 308.63 MiB (-0.04%)

lqd · 2023-11-09T07:37:01Z

The timeouts are most likely related to the perf collector, not this PR.

Update Rust toolchain from nightly-2023-11-09 to nightly-2023-11-10 without any other source changes. This is an automatically generated pull request. If any of the CI checks fail, manual intervention is required. In such a case, review the changes at https://github.com/rust-lang/rust from rust-lang@fdaaaf9 up to rust-lang@0f44eb3. The log for this commit range is: rust-lang@0f44eb32f1 Auto merge of rust-lang#117727 - saethlin:inline-derived-fmt, r=nnethercote rust-lang@eae4135939 Auto merge of rust-lang#117708 - onur-ozkan:x-setup, r=clubby789 rust-lang@4c8862b263 Auto merge of rust-lang#117122 - ferrocene:pa-configure-git-diff, r=albertlarsan68 rust-lang@d32d9238cf Emit #[inline] on derive(Debug) rust-lang@b7583d38b7 Auto merge of rust-lang#117712 - lcnr:expand-coroutine, r=jackh726 rust-lang@488dd9bc73 fmt rust-lang@e7998aa21f Auto merge of rust-lang#117734 - nnethercote:rm-Zstrip, r=davidtwco rust-lang@287ae4db75 Auto merge of rust-lang#117632 - Nilstrieb:icup, r=davidtwco rust-lang@492e57c6ad Auto merge of rust-lang#117736 - TaKO8Ki:rollup-fjrtmlb, r=TaKO8Ki rust-lang@d1e26401bc chore(bootstrap): capitalize {error, warning, info, note} tags rust-lang@42fbf3ebf5 allow users to override the existing configuration during x setup rust-lang@3d6417fc7a check config file before prompts on x setup rust-lang@f5195c52bb Rollup merge of rust-lang#117724 - Kobzol:shim-error-message, r=onur-ozkan rust-lang@e603f4491c Rollup merge of rust-lang#117723 - onur-ozkan:keep-bootstrap-on-x-clean, r=albertlarsan68 rust-lang@6533c62ce7 Rollup merge of rust-lang#117705 - tshepang:patch-2, r=Nilstrieb rust-lang@b4fa5b7004 Rollup merge of rust-lang#117694 - jmillikin:core-io-borrowed-buf, r=m-ou-se rust-lang@4cc549811f Rollup merge of rust-lang#117645 - compiler-errors:auto-trait-subst, r=petrochenkov rust-lang@a1a8d6fe9c Rollup merge of rust-lang#116762 - WaffleLapkin:fixup_fromptr_docs, r=RalfJung rust-lang@d8dbf7ca0e Auto merge of rust-lang#117557 - Zoxc:panic-prio, r=petrochenkov rust-lang@ecc936b155 Remove `-Z strip`. rust-lang@57fb1e643a Auto merge of rust-lang#117454 - shepmaster:github-actions-m1-tests, r=GuillaumeGomez,onur-ozkan rust-lang@341c85648c Move `BorrowedBuf` and `BorrowedCursor` from `std:io` to `core::io` rust-lang@92267c9794 update mir-opt tests rust-lang@992d93f687 rename `BorrowKind::Shallow` to `Fake` rust-lang@a42eca42df generator layout: ignore fake borrows rust-lang@622be2d138 Restore rustc shim error message rust-lang@de0458af97 speed up `x clean` rust-lang@6909992501 Run tests in CI for aarch64-apple-darwin rust-lang@64090536d4 Install tidy for aarch64-apple-darwin rust-lang@469d34b39b Mark Rustdoc test as Linux-only rust-lang@bf360d407e instrument constituent types computation rust-lang@03435e6fdd accept review suggestion rust-lang@769ad29c3e triagebot.toml: use inclusive language rust-lang@102384523a Document how rust atomics work wrt mixed-sized and non-atomic accesses rust-lang@c17d33f1df Extend builtin/auto trait args with error when they have >1 argument rust-lang@580fa0c1a9 rename github_repository to git_repository rust-lang@ffffc2038f Update ICU4X rust-lang@ff1858e2aa Make `FatalErrorMarker` lower priority than other panics rust-lang@4a0873533f update suggest-tests rust-lang@5a562d962e pass the correct args to compiletest rust-lang@545cc830e1 allow configuring the parent GitHub repository Co-authored-by: celinval <celinval@users.noreply.github.com>

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 31, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2023

Auto merge of rust-lang#117454 - shepmaster:github-actions-m1-tests, …

7655317

…r=<try> Run tests in CI for aarch64-apple-darwin r? `@ghost`

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2023

This comment has been minimized.

# to view

shepmaster force-pushed the github-actions-m1-tests branch from bf07b27 to 7a2ab46 Compare October 31, 2023 19:48

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2023

Auto merge of rust-lang#117454 - shepmaster:github-actions-m1-tests, …

223ccde

…r=<try> Run tests in CI for aarch64-apple-darwin r? `@ghost`

This comment has been minimized.

# to view

shepmaster force-pushed the github-actions-m1-tests branch from 7a2ab46 to 83d2dd2 Compare October 31, 2023 20:32

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2023

Auto merge of rust-lang#117454 - shepmaster:github-actions-m1-tests, …

2e94d63

…r=<try> Run tests in CI for aarch64-apple-darwin r? `@ghost`

This comment has been minimized.

# to view

shepmaster force-pushed the github-actions-m1-tests branch from 83d2dd2 to 4e9c7b8 Compare October 31, 2023 20:39

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2023

Auto merge of rust-lang#117454 - shepmaster:github-actions-m1-tests, …

d98697a

…r=<try> Run tests in CI for aarch64-apple-darwin r? `@ghost`

shepmaster force-pushed the github-actions-m1-tests branch from 4e9c7b8 to 788ca2d Compare November 8, 2023 13:35

rustbot assigned Mark-Simulacrum Nov 8, 2023

GuillaumeGomez reviewed Nov 8, 2023

View reviewed changes

tests/rustdoc-ui/issues/issue-107918.rs Outdated Show resolved Hide resolved

shepmaster marked this pull request as ready for review November 8, 2023 13:46

shepmaster added 3 commits November 8, 2023 08:53

Mark Rustdoc test as Linux-only

469d34b

Due to incorrect CI configuration, this test was not being run on macOS. aarch64-apple-darwin will start running it, so we correct the configuration.

Install tidy for aarch64-apple-darwin

6409053

The GitHub Actions image has this preinstalled for x86_64 but not M1.

Run tests in CI for aarch64-apple-darwin

6909992

shepmaster force-pushed the github-actions-m1-tests branch from 788ca2d to 6909992 Compare November 8, 2023 13:55

GuillaumeGomez approved these changes Nov 8, 2023

View reviewed changes

rustbot assigned onur-ozkan and unassigned Mark-Simulacrum Nov 8, 2023

onur-ozkan approved these changes Nov 8, 2023

View reviewed changes

src/ci/scripts/install-tidy.sh Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 8, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 9, 2023

bors merged commit 57fb1e6 into rust-lang:master Nov 9, 2023

rustbot added this to the 1.75.0 milestone Nov 9, 2023

shepmaster deleted the github-actions-m1-tests branch November 9, 2023 01:55

Run tests in CI for aarch64-apple-darwin #117454

Run tests in CI for aarch64-apple-darwin #117454

Uh oh!

Conversation

shepmaster commented Oct 31, 2023

Uh oh!

shepmaster commented Oct 31, 2023

Uh oh!

bors commented Oct 31, 2023

Uh oh!

bors commented Oct 31, 2023

Uh oh!

This comment has been minimized.

shepmaster commented Oct 31, 2023

Uh oh!

bors commented Oct 31, 2023

Uh oh!

bors commented Oct 31, 2023

Uh oh!

This comment has been minimized.

shepmaster commented Oct 31, 2023

Uh oh!

bors commented Oct 31, 2023

Uh oh!

This comment has been minimized.

bors commented Oct 31, 2023

Uh oh!

shepmaster commented Oct 31, 2023

Uh oh!

bors commented Oct 31, 2023

Uh oh!

bors commented Oct 31, 2023

Uh oh!

shepmaster commented Nov 8, 2023

Uh oh!

shepmaster commented Nov 8, 2023

Uh oh!

Uh oh!

GuillaumeGomez commented Nov 8, 2023

Uh oh!

GuillaumeGomez left a comment

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Nov 8, 2023

Uh oh!

onur-ozkan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

onur-ozkan commented Nov 8, 2023

Uh oh!

shepmaster commented Nov 8, 2023

Uh oh!

bors commented Nov 8, 2023

Uh oh!

bors commented Nov 8, 2023

Uh oh!

bors commented Nov 9, 2023

Uh oh!

rust-timer commented Nov 9, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

lqd commented Nov 9, 2023

Uh oh!

Uh oh!