Skip to content

clone less #117540

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2023
Merged

clone less #117540

merged 1 commit into from
Nov 4, 2023

Conversation

matthiaskrgr
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2023

r? @fmease

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 3, 2023
@matthiaskrgr matthiaskrgr force-pushed the baby_dont_clone_me_dont_clone_me_no_more branch from 5da99de to 1ba97cb Compare November 3, 2023 12:23
matthiaskrgr
matthiaskrgr commented Nov 3, 2023
View reviewed changes
src/librustdoc/passes/lint/html_tags.rs
crate::lint::INVALID_HTML_TAGS,
hir_id,
sp,
msg.to_string(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this .to_string() here, rest is formatting

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/rust-lang/rust/pull/117540/files?diff=unified&w=1 helps

@fmease
Copy link
Member

fmease commented Nov 3, 2023

Love the branch name 😂😂

@est31
Copy link
Member

est31 commented Nov 3, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 3, 2023

📌 Commit 1ba97cb has been approved by est31

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2023
@fmease
Copy link
Member

fmease commented Nov 3, 2023 •
edited
Loading

Thanks for approving, I didn't have the time for reviews today.

@nnethercote
Copy link
Contributor

Did you find these manually?

@matthiaskrgr
Copy link
Member Author

I used clippy :)

@nnethercote
Copy link
Contributor

I am still very unclear about the status of using clippy on rustc...

@matthiaskrgr
Copy link
Member Author

Yeah, sometimes it breaks, sometimes it ICES, sometimes you have to manually hack around in x.py to get it to work, its definitely not a tier 1 x.py command 😄

@bors
Copy link
Collaborator

bors commented Nov 4, 2023

⌛ Testing commit 1ba97cb with merge f1b104f...

@est31
Copy link
Member

est31 commented Nov 4, 2023

Thanks for approving, I didn't have the time for reviews today.

Seeing #117537 I just went over the list of open PRs and approved the ones that seemed easy enough to get merged. I hope this lessens the burden a little (279 PRs waiting on review, wow).

@bors
Copy link
Collaborator

bors commented Nov 4, 2023

☀️ Test successful - checks-actions
Approved by: est31
Pushing f1b104f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 4, 2023
@bors bors merged commit f1b104f into rust-lang:master Nov 4, 2023
@rustbot rustbot added this to the 1.75.0 milestone Nov 4, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f1b104f): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Warning ⚠: The following benchmark(s) failed to build:

  • stm32f4-0.14.0
  • webrender-2022

cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 16.5% [1.1%, 30.2%] 3
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 16.5% [1.1%, 30.2%] 3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.5% [0.6%, 2.3%] 5
Regressions ❌
(secondary)		 1.4% [1.4%, 1.4%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.1% [-1.1%, -1.1%] 2
All ❌✅ (primary) 1.5% [0.6%, 2.3%] 5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 8.0% [0.4%, 23.2%] 5
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 8.0% [0.4%, 23.2%] 5

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.085s -> 635.352s (0.20%)
Artifact size: 304.52 MiB -> 304.45 MiB (-0.02%)

@rustbot rustbot added the perf-regression Performance regression. label Nov 4, 2023
@matthiaskrgr
Copy link
Member Author

seems to be the same noise as in https://github.com/rust-lang/rust/pull/115333/files (a comment-only pr)

@github-actions github-actions bot mentioned this pull request Nov 6, 2023
Merged
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request Nov 6, 2023
@bors-ferrocene @BenWiederhake
@SabrinaJewson @J-ZhengLi @koka831 @bjorn3 @joshlf @lengyijun @Zalathar @oli-obk @flip1995 @y21 @bors @bvanjoi
Merge #84
a01e81f 
84: Automated pull from upstream `master` r=Dajamante a=github-actions[bot]


This PR pulls the following changes from the upstream repository:

* rust-lang/rust#117585
* rust-lang/rust#117576
* rust-lang/rust#96979
* rust-lang/rust#117191
* rust-lang/rust#117179
* rust-lang/rust#117574
* rust-lang/rust#117537
* rust-lang/rust#117608
  * rust-lang/rust#117596
  * rust-lang/rust#117588
  * rust-lang/rust#117524
  * rust-lang/rust#116017
* rust-lang/rust#117504
* rust-lang/rust#117469
* rust-lang/rust#116218
* rust-lang/rust#117589
* rust-lang/rust#117581
* rust-lang/rust#117503
* rust-lang/rust#117590
  * rust-lang/rust#117583
  * rust-lang/rust#117570
  * rust-lang/rust#117562
  * rust-lang/rust#117534
  * rust-lang/rust#116894
  * rust-lang/rust#110340
* rust-lang/rust#113343
* rust-lang/rust#117579
* rust-lang/rust#117094
* rust-lang/rust#117566
* rust-lang/rust#117564
  * rust-lang/rust#117554
  * rust-lang/rust#117550
  * rust-lang/rust#117343
* rust-lang/rust#115274
* rust-lang/rust#117540
* rust-lang/rust#116412
* rust-lang/rust#115333
* rust-lang/rust#117507
* rust-lang/rust#117538
  * rust-lang/rust#117533
  * rust-lang/rust#117523
  * rust-lang/rust#117520
  * rust-lang/rust#117505
  * rust-lang/rust#117434
* rust-lang/rust#117535
* rust-lang/rust#117510
* rust-lang/rust#116439
* rust-lang/rust#117508



Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de>
Co-authored-by: SabrinaJewson <sejewson@gmail.com>
Co-authored-by: J-ZhengLi <lizheng135@huawei.com>
Co-authored-by: koka <koka.code@gmail.com>
Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
Co-authored-by: Joshua Liebow-Feeser <joshlf@users.noreply.github.com>
Co-authored-by: lengyijun <sjtu5140809011@gmail.com>
Co-authored-by: Zalathar <Zalathar@users.noreply.github.com>
Co-authored-by: Oli Scherer <git-spam-no-reply9815368754983@oli-obk.de>
Co-authored-by: Philipp Krones <hello@philkrones.com>
Co-authored-by: y21 <30553356+y21@users.noreply.github.com>
Co-authored-by: bors <bors@rust-lang.org>
Co-authored-by: bohan <bohan-zhang@foxmail.com>
@pnkfelix
Copy link
Member

pnkfelix commented Nov 7, 2023

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Nov 7, 2023
@matthiaskrgr matthiaskrgr deleted the baby_dont_clone_me_dont_clone_me_no_more branch January 25, 2025 09:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fbstj fbstj fbstj left review comments

Assignees

@fmease fmease

Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.75.0
Development

Successfully merging this pull request may close these issues.
9 participants
@matthiaskrgr @rustbot @fmease @est31 @bors @nnethercote @rust-timer @pnkfelix @fbstj