Skip to content

[DO NOT MERGE] Sync from ra experiment #117544

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 198 commits into from
Closed

[DO NOT MERGE] Sync from ra experiment #117544

wants to merge 198 commits into from

Conversation

HKalbasi
Copy link
Member

@HKalbasi HKalbasi commented Nov 3, 2023

r? @ghost

RalfJung and others added 30 commits August 21, 2023 10:41
@RalfJung
extend check.overrideCommand and buildScripts.overrideCommand docs re…
940d87b 
…garding invocation strategy and location
@RalfJung
projects/workspaces
2de62be
@vxpm
full function signatures option
23ffda1
@vxpm
better handling of spaces & newlines
6afa5b0
@vxpm
fix & run tests
6b487ed
@rmehri01
feat: initial version of bool_to_enum assist
d7a8e80
@rmehri01
fix: add generated doctest
59738d5
@rmehri01
fix: remove trailing whitespace
83196fd
@rmehri01
fix: initializing struct multiple times
91ac1d6
@rmehri01
fix: only trigger assist on Name
455dacf
@rmehri01
style: rename some locals
136a9db
@rmehri01
feat: support cross module imports
2e13aed
@rmehri01
fix: add checks for overwriting incorrect ancestor
7ba2e13
@alibektas
Deunwrap inline call
5683df2
@alibektas
Deunwrap inline call v2
68d24b6
@alibektas
v3
38491fc
@alibektas
Deunwrap convert_comment_block
9c62571
@alibektas
replace for loops with sth more idiomatic
b316bcc
@alibektas
v2
a66dbd1
@alibektas
v3
2fdf7e4
@rmehri01
feat: add support for other ADT types and destructuring patterns
25b1b3e
@alibektas
Make assist lazy again
0863024
@alibektas
Make assist lazy again
893e191
@alibektas
Deunwrap add_missing_match_arms
145a101
@dfireBird
remove as _ on auto importing on trait that is aliased with _
d794865
@dfireBird
add tests for insert use with renamed imports
df1239b 
Tested for two cases:
1. Simple Use
2. Complex Use
@davidbarsky
fix: ensure rustfmt runs when configured with ./
2974416
@shogo-nakano-desu
refactor: fix clippy lints
ebbbaaa
@shogo-nakano-desu
refactor: remove TODO with no explanation
0bb2298
@shogo-nakano-desu
refactor: fix clippy lint
96c3332
Young-Flash and others added 19 commits October 14, 2023 11:05
@Young-Flash
feat: make cursor select at _tmp
bc34e8f
@harpsword
fix: fix typo in mbe/lib.rs comment
3f4368a
@bors
Auto merge of rust-lang#15756 - harpsword:fix_typo_in_mbe_lib, r=lnicola
16ac6c2 
fix typo in mbe/lib.rs comment

fix typo in mbe/lib.rs comment
@ChristianSchott
make ProjectionStore-impls pub-accessible
8217ff9
@bors
Auto merge of rust-lang#15760 - ChristianSchott:master, r=HKalbasi
dbe5392 
make mir::ProjectionStore-impls pub-accessible

When using RA as a crate the `mir::Place` `projection` is accessible, however there is no way to translate the `ProjectionId` to a `&[PlaceElem]`, as the `ProjectionId::lookup` is private.

Personally, I would only need the `ProjectionId::lookup`-fn to be `pub`, but I don't see any reason why the others should be kept private.. am I missing something `@HKalbasi` ?

Relates to: rust-lang/rust-analyzer#15575
@bors
Auto merge of rust-lang#15755 - Young-Flash:cursor_selection, r=lnicola
65532e4 
fix: make cursor select at _tmp

Here make cursor select at `_tmp` atuomatically after the assist apply. Refer to [vscode snippet placeholder](https://code.visualstudio.com/docs/editor/userdefinedsnippets#_placeholders).

![cursor_selection](https://github.com/rust-lang/rust-analyzer/assets/71162630/a7866efe-2d54-488b-903e-9df039f34a7e)

following rust-lang/rust-analyzer#15752
@Veykril
Fix metrics workflow to use deploy key
d33fd15
@bors
Auto merge of rust-lang#15762 - Veykril:metrics-deploy, r=Veykril
a8581aa 
fix: Fix metrics workflow to use deploy key

I think this should be correct
@Veykril
Update rustc_abi dependency
40acc52
@bors
Auto merge of rust-lang#15691 - Veykril:rustc_abi, r=Veykril
6572ec8 
Update rustc_abi dependency

cc rust-lang#116269
@Wilfred
Expand Emacs documentation
03bec11 
Emacs 29 is now released, and include an example of enabling clippy.
@bors
Auto merge of rust-lang#15764 - Wilfred:emacs_docs, r=lnicola
983094a 
Expand Emacs documentation

Emacs 29 is now released, and include an example of enabling clippy.
@lnicola
Create .ssh before writing deploy key
222be48
@bors
Auto merge of rust-lang#15769 - lnicola:metrics-ssh, r=lnicola
03f676e 
internal: Create `~/.ssh` before writing deploy key
@lnicola
Fix metrics repo url
490cdfe
@bors
Auto merge of rust-lang#15770 - lnicola:metrics-url, r=lnicola
2910dbf 
internal: Fix metrics repo url
@bors
Auto merge of rust-lang#15746 - pvalletbo:string-literals-diagnose, r…
d6afb4f 
…=Veykril

String literals diagnose

Continues the work from rust-lang#15744 to add diagnosis errors to Str, ByteStr, and CStr literal kinds.

Also replaces `unescape_char` for `unescape_byte` to use the correct method for Byte literals.
@lnicola
Merge commit 'd6afb4fa239fe7b5b34e5cefa9e58148fdff65b8' into sync-fro…
520aad1 
…m-ra
@HKalbasi
use path dependency instead of rustc_private
23f9077
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 3, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2023

Some changes occurred in src/tools/rust-analyzer

cc @rust-lang/rust-analyzer

@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 3, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2023

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits:

@rust-log-analyzer

This comment has been minimized.

# to view
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_afbc90a1-bfd6-47d2-9171-0223003d842f
GITHUB_EVENT_NAME=pull_request
GITHUB_EVENT_PATH=/home/runner/work/_temp/_github_workflow/event.json
GITHUB_GRAPHQL_URL=https://api.github.com/graphql
GITHUB_HEAD_REF=sync-from-ra-experiment
GITHUB_JOB=pr
GITHUB_PATH=/home/runner/work/_temp/_runner_file_commands/add_path_afbc90a1-bfd6-47d2-9171-0223003d842f
GITHUB_REF=refs/pull/117544/merge
GITHUB_REF_NAME=117544/merge
GITHUB_REF_PROTECTED=false
---
    Finished release [optimized] target(s) in 12.20s
##[endgroup]
##[group]Checking stage0 rust-analyzer artifacts (x86_64-unknown-linux-gnu -> i686-pc-windows-gnu)
    Updating crates.io index
error: the lock file /checkout/src/tools/rust-analyzer/Cargo.lock needs to be updated but --locked was passed to prevent this
If you want to try to generate the lock file without accessing the network, remove the --locked flag and use --offline instead.
  local time: Fri Nov  3 14:58:28 UTC 2023
  network time: Fri, 03 Nov 2023 14:58:29 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@lnicola lnicola mentioned this pull request Nov 4, 2023
Closed
@HKalbasi HKalbasi closed this Nov 4, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.