Skip to content

Uplift CanonicalVarInfo and friends into rustc_type_ir #117582

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 22, 2023
Merged

Uplift CanonicalVarInfo and friends into rustc_type_ir #117582

merged 2 commits into from
Nov 22, 2023

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Nov 4, 2023 •
edited
Loading

Depends on #117580 and #117578

Uplift CanonicalVarInfo and friends into rustc_type_ir so they can be consumed by an interner-agnostic Canonicalizer implementation for the new trait solver ❤️

r? @ghost

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 4, 2023
@compiler-errors compiler-errors changed the title Uplift canonical var Uplift CanonicalVarInfo and friends into rustc_type_ir Nov 4, 2023
@bors
Copy link
Collaborator

bors commented Nov 5, 2023

☔ The latest upstream changes (presumably #117590) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-cloud-vms rust-cloud-vms bot force-pushed the uplift-canonical-var branch from ea26331 to 047fe79 Compare November 6, 2023 23:44
@bors
Copy link
Collaborator

bors commented Nov 13, 2023

☔ The latest upstream changes (presumably #117876) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

This comment has been minimized.

# to view
@bors
Copy link
Collaborator

bors commented Nov 14, 2023

☔ The latest upstream changes (presumably #117731) made this pull request unmergeable. Please resolve the merge conflicts.

@jackh726
Copy link
Member

r=me when other one lands

@bors
Copy link
Collaborator

bors commented Nov 20, 2023

☔ The latest upstream changes (presumably #116828) made this pull request unmergeable. Please resolve the merge conflicts.

@compiler-errors compiler-errors marked this pull request as ready for review November 21, 2023 17:47
@compiler-errors
Copy link
Member Author

@bors r=jackh726

@bors
Copy link
Collaborator

bors commented Nov 21, 2023

📌 Commit d1daf0e has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2023
@bors
Copy link
Collaborator

bors commented Nov 22, 2023

⌛ Testing commit d1daf0e with merge 739d556...

@bors
Copy link
Collaborator

bors commented Nov 22, 2023

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 739d556 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 22, 2023
@bors bors merged commit 739d556 into rust-lang:master Nov 22, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 22, 2023
@compiler-errors compiler-errors deleted the uplift-canonical-var branch November 22, 2023 05:23
@bors bors mentioned this pull request Nov 22, 2023
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (739d556): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.8% [0.8%, 0.8%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.7% [-0.7%, -0.7%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 676.516s -> 676.959s (0.07%)
Artifact size: 313.79 MiB -> 313.78 MiB (-0.00%)

@jackh726 jackh726 mentioned this pull request Nov 30, 2023
Open
26 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
6 participants
@compiler-errors @bors @rust-log-analyzer @jackh726 @rust-timer @rustbot