-
Notifications
You must be signed in to change notification settings - Fork 13.5k
llvm-wrapper: remove some unused headers #117676
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version from 'uint64_t' to 'unsigned int', possible loss of data https://github.com/llvm/llvm-project/blame/release/16.x/llvm/include/llvm/IR/DiagnosticInfo.h 3 versions of getLocCookie returns: 1 uint64_t and 2 unsigned, nice consistency.
r? @cuviper (rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
The job Click to see the possible cause of the failure (guessed by this bot)
|
@rustbot author |
☔ The latest upstream changes (presumably #117680) made this pull request unmergeable. Please resolve the merge conflicts. |
@klensy any updates on this? thanks |
Closing this as inactive. Feel free to reöpen this pr or create a new pr if you get the time to work on this. Thanks |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw #117675 and #117674 and remembered, that i wrote this PR, but forgot to submit.
Also fixes warning about type conversion.
Probably can fail, as this PR from long time ago.