Skip to content

Add missing entries in 1.74 release notes #117917

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Add missing entries in 1.74 release notes #117917

merged 2 commits into from
Nov 15, 2023

Conversation

slanterns
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Nov 14, 2023
@Mark-Simulacrum
Copy link
Member

Hm I thought I had rebased over those changes in the previous PR, but I suppose not.

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 14, 2023

📌 Commit 7f10299 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2023
@Mark-Simulacrum
Copy link
Member

@bors p=1

@slanterns
Copy link
Contributor Author

@Mark-Simulacrum Caught a small tidy fix. Please take a look again ^_^

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 15, 2023

📌 Commit 563d975 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 15, 2023

⌛ Testing commit 563d975 with merge cc8681b...

@bors
Copy link
Collaborator

bors commented Nov 15, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing cc8681b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 15, 2023
@bors bors merged commit cc8681b into rust-lang:master Nov 15, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 15, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cc8681b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.4% [0.4%, 0.4%] 1
Regressions ❌
(secondary)
2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)
-1.0% [-1.7%, -0.4%] 4
Improvements ✅
(secondary)
-3.7% [-3.7%, -3.7%] 1
All ❌✅ (primary) -0.7% [-1.7%, 0.4%] 5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.4% [0.4%, 0.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.4% [0.4%, 0.4%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 676.301s -> 674.399s (-0.28%)
Artifact size: 311.10 MiB -> 311.08 MiB (-0.00%)

@slanterns slanterns deleted the slanterns-1.74-release_note branch June 8, 2024 05:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants