Skip to content

Add an experimental feature gate for function delegation #117978

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Nov 16, 2023

In accordance with the process.

Detailed description of the feature can be found in the RFC repo - rust-lang/rfcs#3530.

TODO: find a lang team liaison - https://rust-lang.zulipchat.com/#narrow/stream/213817-t-lang/topic/fn.20delegation.20liaison/near/402506959.

@rustbot
Copy link
Collaborator

rustbot commented Nov 16, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 16, 2023
@petrochenkov petrochenkov added T-lang Relevant to the language team S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2023
@rust-log-analyzer

This comment has been minimized.

Copy link
Member

@TaKO8Ki TaKO8Ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding fn_delegation to sym, r=me

@petrochenkov petrochenkov added the I-lang-nominated Nominated for discussion during a lang team meeting. label Nov 20, 2023
@joshtriplett joshtriplett removed the I-lang-nominated Nominated for discussion during a lang team meeting. label Nov 22, 2023
@joshtriplett
Copy link
Member

In today's meeting, we approved this for experimentation. @traviscross will liaise with the lang team.

Thanks for working on this, @petrochenkov!

@traviscross traviscross removed the S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). label Nov 22, 2023
@petrochenkov
Copy link
Contributor Author

@bors r=TaKO8Ki,joshtriplett

@bors
Copy link
Collaborator

bors commented Nov 23, 2023

📌 Commit edf6c9c has been approved by TaKO8Ki,joshtriplett

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 23, 2023
@bors
Copy link
Collaborator

bors commented Nov 23, 2023

⌛ Testing commit edf6c9c with merge 237339f...

@bors
Copy link
Collaborator

bors commented Nov 23, 2023

☀️ Test successful - checks-actions
Approved by: TaKO8Ki,joshtriplett
Pushing 237339f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 23, 2023
@bors bors merged commit 237339f into rust-lang:master Nov 23, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 23, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (237339f): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.2% [-0.2%, -0.2%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 677.025s -> 676.283s (-0.11%)
Artifact size: 313.73 MiB -> 313.72 MiB (-0.00%)

@fmease fmease added the F-fn_delegation `#![feature(fn_delegation)]` label Jan 13, 2024
@petrochenkov petrochenkov deleted the deleggate branch February 22, 2025 18:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
F-fn_delegation `#![feature(fn_delegation)]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants