Skip to content

Remove unnecessary -fembed-bitcode usage now that it's deprecated #118014

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

keith
Copy link
Contributor

@keith keith commented Nov 17, 2023

This is a partial revert of 6d819a4 because rust-lang/cc-rs#812 removed this flag entirely, meaning we shouldn't have to pass this manually anymore

@rustbot
Copy link
Collaborator

rustbot commented Nov 17, 2023

r? @clubby789

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 17, 2023
@keith
Copy link
Contributor Author

keith commented Nov 17, 2023

This depends on that linked PR being in a cc-rs release, which it was but that version was yanked https://github.com/rust-lang/cc-rs/releases/tag/1.0.84, we need to wait to merge this until that's ready, but I wanted to get CI running now

@bors
Copy link
Collaborator

bors commented May 7, 2024

☔ The latest upstream changes (presumably #122504) made this pull request unmergeable. Please resolve the merge conflicts.

This is a partial revert of 6d819a4
because rust-lang/cc-rs#812 removed this flag
entirely, meaning we shouldn't have to pass this manually anymore
@keith keith force-pushed the ks/remove-unnecessary-fembed-bitcode-usage-now-that-it-s-deprecated branch from f490968 to 096a08e Compare May 7, 2024 16:26
@keith keith marked this pull request as ready for review May 7, 2024 16:26
@rustbot
Copy link
Collaborator

rustbot commented May 7, 2024

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

@keith
Copy link
Contributor Author

keith commented May 7, 2024

there have been a few cc-rs updates since, so i think we should be ready here

@clubby789
Copy link
Contributor

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented May 20, 2024

📌 Commit 096a08e has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2024
@bors
Copy link
Collaborator

bors commented May 20, 2024

⌛ Testing commit 096a08e with merge 474bee7...

@bors
Copy link
Collaborator

bors commented May 20, 2024

☀️ Test successful - checks-actions
Approved by: clubby789
Pushing 474bee7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 20, 2024
@bors bors merged commit 474bee7 into rust-lang:master May 20, 2024
7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 20, 2024
@keith keith deleted the ks/remove-unnecessary-fembed-bitcode-usage-now-that-it-s-deprecated branch May 20, 2024 18:37
@keith
Copy link
Contributor Author

keith commented May 20, 2024

thanks!

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (474bee7): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.2% [0.2%, 0.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.3% [-1.3%, -1.3%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -1.4%, secondary -1.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.3% [4.3%, 4.3%] 1
Improvements ✅
(primary)
-1.4% [-3.5%, -0.7%] 4
Improvements ✅
(secondary)
-2.3% [-2.7%, -1.9%] 5
All ❌✅ (primary) -1.4% [-3.5%, -0.7%] 4

Cycles

Results (secondary 6.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
6.4% [3.1%, 8.3%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.213s -> 670.162s (-0.16%)
Artifact size: 315.91 MiB -> 316.04 MiB (0.04%)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants