Skip to content

Remove a hack for effects #118246

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Remove a hack for effects #118246

merged 1 commit into from
Nov 24, 2023

Conversation

fee1-dead
Copy link
Member

Fallback was implemented in #115727, which addresses the inference errors mentioned in the comments.

@rustbot
Copy link
Collaborator

rustbot commented Nov 24, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 24, 2023
@fee1-dead
Copy link
Member Author

r? @compiler-errors

Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 24, 2023

📌 Commit 0626de4 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2023
…mpiler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#118187 (Recompile LLVM when it changes in the git sources)
 - rust-lang#118210 (intercrate ambiguity causes: ignore candidates which don't apply)
 - rust-lang#118215 (Add common trait for crate definitions)
 - rust-lang#118238 (memcpy assumptions: update GCC link)
 - rust-lang#118243 (EvalCtxt::commit_if_ok don't inherit nested goals)
 - rust-lang#118245 (Add `Span` to `TraitBoundModifier`)
 - rust-lang#118246 (Remove a hack for effects)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 592ee12 into rust-lang:master Nov 24, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2023
Rollup merge of rust-lang#118246 - fee1-dead-contrib:rm-hack, r=compiler-errors

Remove a hack for effects

Fallback was implemented in rust-lang#115727, which addresses the inference errors mentioned in the comments.
@rustbot rustbot added this to the 1.76.0 milestone Nov 24, 2023
@fee1-dead fee1-dead deleted the rm-hack branch November 25, 2023 13:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants