Rollup of 6 pull requests #118294
Merged
Rollup of 6 pull requests #118294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Option::unwrap` is called on the next line.
And move declarative macro compilation to an earlier point in def collector, which is required for rust-lang#118188.
…_const, r=b-naber Yeet `mir::Const::from_anon_const` Only had one callsite which was easily simplified. Uplifted a comment that I think is much more useful living in `ty::Const` world.
remove unused pub fns This removes some unused `pub fn`; also fixes few obsoleted fn names or added fixmes with reminders to update them.
rustc_lint: address latent TODO See individual commits.
Remove `HirId` from `QPath::LangItem` Remove `HirId` from `QPath::LangItem`, since there was only *one* use-case (`ObligationCauseCode::AwaitableExpr`), which we can instead recover by walking the HIR tree.
resolve: Avoid clones of `MacroData` And move declarative macro compilation to an earlier point in def collector, which is required for rust-lang#118188.
…GuillaumeGomez rustdoc-search: clean up some DOM code
rustbot
added
S-waiting-on-review
|
@bors r+ p=6 rollup=never |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 16087eeea8 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Nov 25, 2023
|
Finished benchmarking commit (ec1393f): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 674.958s -> 675.077s (0.02%) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
mir::Const::from_anon_const#116446 (Yeetmir::Const::from_anon_const)HirIdfromQPath::LangItem#118199 (RemoveHirIdfromQPath::LangItem)MacroData#118272 (resolve: Avoid clones ofMacroData)Failed merges:
ObligationCauseCodecleanups #118201 (MiscellaneousObligationCauseCodecleanups)hir().local_def_id_to_hir_id()->tcx.local_def_id_to_hir_id()cleanup #118256 (rustc:hir().local_def_id_to_hir_id()->tcx.local_def_id_to_hir_id()cleanup)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup