Skip to content

Backticks fixes #118338

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2023
Merged

Backticks fixes #118338

merged 2 commits into from
Nov 27, 2023

Conversation

nnethercote
Copy link
Contributor

r? @lqd

@nnethercote
Put backticks around some attributes in doc comments.
f1eee28 
Without backticks they cause some "unresolved link to `foo`" warnings.
@nnethercote
Fix some backticks in comments.
566df27
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 26, 2023
@nnethercote
Copy link
Contributor Author

The first commit fixes these warnings, and the second commit fixes something I noticed along the way.

@nnethercote nnethercote mentioned this pull request Nov 26, 2023
Merged
@nnethercote
Copy link
Contributor Author

@bors rollup

@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 26, 2023

📌 Commit 566df27 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 27, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 27, 2023
@bors
Auto merge of rust-lang#118353 - matthiaskrgr:rollup-sf1booi, r=matth…
cc11307 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#118322 (skip {tidy,compiletest,rustdoc-gui} based tests for `DocTests::Only`)
 - rust-lang#118325 (Fix Rustdoc search docs link)
 - rust-lang#118338 (Backticks fixes)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 96cd028 into rust-lang:master Nov 27, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 27, 2023
@rust-timer
Unrolled build for rust-lang#118338
51db070 
Rollup merge of rust-lang#118338 - nnethercote:backticks, r=compiler-errors

Backticks fixes

r? `@lqd`
@rustbot rustbot added this to the 1.76.0 milestone Nov 27, 2023
@nnethercote nnethercote deleted the backticks branch November 27, 2023 21:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nnethercote @compiler-errors @bors @lqd @rustbot