Skip to content

Update to LLVM 17.0.6 #118936

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Update to LLVM 17.0.6 #118936

merged 3 commits into from
Dec 15, 2023

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Dec 14, 2023

This is a rebase on the final LLVM 17 release.

Includes the RISCV fix requested in rust-lang/llvm-project#157 (and I think this is also the only change in this release that is relevant to rustc).

r? @cuviper

Fixes #117902

@rustbot
Copy link
Collaborator

rustbot commented Dec 14, 2023

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 14, 2023
@rust-log-analyzer

This comment has been minimized.

@nikic
Copy link
Contributor Author

nikic commented Dec 14, 2023

Awesome, looks like LLVM updates are broken again.

Failing assertion:

assert_eq!(parse_llvm(""), if_unchanged);

@dianqk
Copy link
Member

dianqk commented Dec 14, 2023

Will backport to beta? llvm/llvm-project#75184 has been merged.

There are a number of fixes here:
 * if-unchanged is supposed to be the default for channel=dev, but
   actually used different logic. Make sure it is the same.
 * If no llvm section was specified at all, different logic was
   also used. Go through the standard helper.
 * Some more assertions should depend on if_unchanged.
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Dec 14, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 14, 2023

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs and change-id in config.example.toml.

@nikic
Copy link
Contributor Author

nikic commented Dec 14, 2023

@dianqk Thanks, I have included the additional cherry-pick.

@wesleywiser wesleywiser added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 14, 2023
@wesleywiser
Copy link
Member

Nominating for beta-backport as the cherry-pick includes a fix for #117902

@wesleywiser
Copy link
Member

@bors p=1

Fixes P-critical and I-unsound issue

@apiraino
Copy link
Contributor

Beta backport approved as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 14, 2023
@cuviper
Copy link
Member

cuviper commented Dec 15, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 15, 2023

📌 Commit 601d52a has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2023
@bors
Copy link
Collaborator

bors commented Dec 15, 2023

⌛ Testing commit 601d52a with merge 604f185...

@bors
Copy link
Collaborator

bors commented Dec 15, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 604f185 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 15, 2023
@bors bors merged commit 604f185 into rust-lang:master Dec 15, 2023
@rustbot rustbot added this to the 1.76.0 milestone Dec 15, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (604f185): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.2% [0.2%, 0.2%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.2% [0.2%, 0.2%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.7% [-0.8%, -0.6%] 3
Improvements ✅
(secondary)
-1.7% [-2.2%, -1.3%] 2
All ❌✅ (primary) -0.7% [-0.8%, -0.6%] 3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.8% [0.5%, 1.6%] 4
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.8% [0.5%, 1.6%] 4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.324s -> 670.068s (-0.19%)
Artifact size: 312.42 MiB -> 312.45 MiB (0.01%)

@cuviper cuviper mentioned this pull request Dec 15, 2023
@cuviper cuviper removed this from the 1.76.0 milestone Dec 15, 2023
@cuviper cuviper added this to the 1.75.0 milestone Dec 15, 2023
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 15, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 16, 2023
[beta] backports

- temporarily revert "ice on ambguity in mir typeck" rust-lang#118736
- Update to LLVM 17.0.6 rust-lang#118936

r? ghost
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 16, 2023
[beta] backports

- temporarily revert "ice on ambguity in mir typeck" rust-lang#118736
- Update to LLVM 17.0.6 rust-lang#118936

r? ghost
@rubdos rubdos mentioned this pull request Dec 29, 2023
@workingjubilee workingjubilee added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label May 26, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Miscompilation of Bevy (and some wgpu) apps resulting in segfault on macOS.
10 participants