Skip to content

Don't drop a hir node after lowering #119284

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2023
Merged

Don't drop a hir node after lowering #119284

merged 1 commit into from
Dec 31, 2023
+38 −3

Conversation

Nadrieril
Copy link
Member

Fixes #119271.

It seems that all hir nodes that get allocated an id must be placed within the hir on pain of ICEs. In #118527 I dropped guards on never patterns since they're not useful, which caused the ICE.

@rustbot
Copy link
Collaborator

rustbot commented Dec 24, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 24, 2023
@cjgillot
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 25, 2023

📌 Commit 5ae3ef7 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2023
@Nadrieril
Copy link
Member Author

Thank you!

@Nadrieril
Copy link
Member Author

Et joyeux Noël !

@bors
Copy link
Collaborator

bors commented Dec 26, 2023

☔ The latest upstream changes (presumably #119146) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 26, 2023
@Nadrieril Nadrieril force-pushed the fix-bodiless-arm-parse branch from 5ae3ef7 to d5b2d88 Compare December 26, 2023 08:48
@Nadrieril
Copy link
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 26, 2023
@Kobzol
Copy link
Member

Kobzol commented Dec 30, 2023

Looks like this wasn't picked up by bors correctly. @cjgillot are you ok with the latest commit? This should be reapproved.

@cjgillot
Copy link
Contributor

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 30, 2023
@cjgillot
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 30, 2023

📌 Commit d5b2d88 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 30, 2023
@bors
Copy link
Collaborator

bors commented Dec 30, 2023

⌛ Testing commit d5b2d88 with merge d868bc2...

@bors
Copy link
Collaborator

bors commented Dec 31, 2023

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing d868bc2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 31, 2023
@bors bors merged commit d868bc2 into rust-lang:master Dec 31, 2023
@rustbot rustbot added this to the 1.77.0 milestone Dec 31, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d868bc2): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.9% [2.9%, 2.9%] 1
Improvements ✅
(primary)		 -0.6% [-0.7%, -0.4%] 2
Improvements ✅
(secondary)		 -2.9% [-2.9%, -2.9%] 1
All ❌✅ (primary) -0.6% [-0.7%, -0.4%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.562s -> 669.056s (-0.08%)
Artifact size: 311.76 MiB -> 311.78 MiB (0.01%)

@Nadrieril Nadrieril deleted the fix-bodiless-arm-parse branch December 31, 2023 09:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

ICE: No parent for node HirId(...)
7 participants
@Nadrieril @rustbot @cjgillot @bors @Kobzol @rust-timer @petrochenkov