Skip to content

Rollup of 3 pull requests #119313

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 26, 2023
Merged

Rollup of 3 pull requests #119313

merged 7 commits into from
Dec 26, 2023

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

AlexBuz and others added 7 commits December 24, 2023 19:28
@AlexBuz
Fix doc typo for read_exact_at
3896f0b
@jyn514
fix ./configure --set change-id
0e88874
@GuillaumeGomez
Update sysinfo version to 0.30.1
51dff45
@GuillaumeGomez
Update sysinfo sub-dependency version to 0.29.11
c2dcfc7
@matthiaskrgr
Rollup merge of rust-lang#119287 - AlexBuz:patch-1, r=the8472
e1b3f45 
Fix doc typo for read_exact_at

This adds an "s" at the end of "byte" to make it plural, as it should be here.
@matthiaskrgr
Rollup merge of rust-lang#119294 - jyn514:configure-change-id, r=onur…
c59de6b 
…-ozkan

fix `./configure --set change-id`

the logic for this is kinda hacky and treats whitespace as significant https://github.com/rust-lang/rust/blob/d1e26401bc70a58e6daf1816d542be4573bbab84/src/bootstrap/configure.py#L485-L491

r? ``@onur-ozkan``
@matthiaskrgr
Rollup merge of rust-lang#119303 - GuillaumeGomez:update-sysinfo, r=o…
f7dc91f 
…nur-ozkan

Update sysinfo

A small bugfix was released for sysinfo so updating once again.

r? ``@onur-ozkan``
@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 26, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=3

@bors
Copy link
Collaborator

bors commented Dec 26, 2023

📌 Commit f7dc91f has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2023
@bors
Copy link
Collaborator

bors commented Dec 26, 2023

⌛ Testing commit f7dc91f with merge a815c3b...

@bors
Copy link
Collaborator

bors commented Dec 26, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing a815c3b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 26, 2023
@bors bors merged commit a815c3b into rust-lang:master Dec 26, 2023
@rustbot rustbot added this to the 1.77.0 milestone Dec 26, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#119287 Fix doc typo for read_exact_at 4224ee8e5204e930cd0bfa0fea3ef1ed55f23976 (link)
#119294 fix ./configure --set change-id e4804398a494d50689e6504a02f09c27619f198c (link)
#119303 Update sysinfo 93423e02004897d8fca17a34ce588e16e2c329a0 (link)

previous master: f6456285dd

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a815c3b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.5% [-1.5%, -1.5%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.2% [-1.3%, -0.9%] 3
Improvements ✅
(secondary)		 -3.3% [-3.6%, -3.0%] 3
All ❌✅ (primary) -1.2% [-1.3%, -0.9%] 3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.254s -> 671.056s (-0.03%)
Artifact size: 312.53 MiB -> 312.53 MiB (-0.00%)

@matthiaskrgr matthiaskrgr deleted the rollup-41x48j6 branch March 16, 2024 18:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. O-unix Operating system: Unix-like rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
7 participants
@matthiaskrgr @bors @rust-timer @rustbot @AlexBuz @jyn514 @GuillaumeGomez