Skip to content

solaris support on bootstrap lock #119413

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Conversation

onur-ozkan
Copy link
Member

With yoshuawuyts/fd-lock#48, fd-lock now supports Solaris. Therefore we no longer need to conditionally handle the bootstrap locks.

@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 29, 2023
@onur-ozkan onur-ozkan added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2023
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
Copy link
Member Author

r? bootstrap (seems like Mark have too many PRs to review)

@onur-ozkan onur-ozkan added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 29, 2023
@Mark-Simulacrum
Copy link
Member

@bors r+

r? @Mark-Simulacrum

I only have 14 PRs in my queue: https://github.com/rust-lang/rust/pulls?q=is%3Aopen+is%3Apr+assignee%3AMark-Simulacrum+label%3AS-waiting-on-review+sort%3Acreated-asc -- there are a bunch not waiting for review, but I don't look at those.

@bors
Copy link
Collaborator

bors commented Dec 29, 2023

📌 Commit 48309f4 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2023
@onur-ozkan
Copy link
Member Author

I only have 14 PRs in my queue: https://github.com/rust-lang/rust/pulls?q=is%3Aopen+is%3Apr+assignee%3AMark-Simulacrum+label%3AS-waiting-on-review+sort%3Acreated-asc -- there are a bunch not waiting for review, but I don't look at those.

Sorry, I quickly checked all the assigned without the status of PRs.

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 30, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#119158 (Clean up alloc::sync::Weak Clone implementation)
 - rust-lang#119386 (fix typo in `IpAddr::to_canonical`)
 - rust-lang#119413 (solaris support on bootstrap lock)
 - rust-lang#119424 (Primitive docs: fix confusing `Send` in `&T`'s list)
 - rust-lang#119425 (Fix invalid check-cfg Cargo feature diagnostic help)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 31aa239 into rust-lang:master Dec 30, 2023
@rustbot rustbot added this to the 1.77.0 milestone Dec 30, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 30, 2023
Rollup merge of rust-lang#119413 - onur-ozkan:bump-fd-lock, r=Mark-Simulacrum

solaris support on bootstrap lock

With yoshuawuyts/fd-lock#48, `fd-lock` now supports Solaris. Therefore we no longer need to conditionally handle the bootstrap locks.
@bors
Copy link
Collaborator

bors commented Dec 30, 2023

⌛ Testing commit 48309f4 with merge d59f06f...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants