-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Gate PR CI on clippy correctness lints #119451
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
r=me when MCP is ready to go |
As this affects libs too, should this be t-libs-nominated so it can be put on the agenda for discussion? |
Should lints use the cargo lints table rather than CI config? So it's easier to check the same flags locally. |
I guess that eventually we could use it, but A benefit of [lints.clippy]
all = { level = "allow", priority = -1 }
correctness = "deny" We would probably have to set this for all crates in |
Needs #119449, which I've nominated. |
#119449 has been merged, let's see if PR CI passes. |
Looks like CI is green. @rustbot ready |
@bors r+ |
…crum Gate PR CI on clippy correctness lints Implements part of rust-lang/compiler-team#709. Note that `x.py clippy compiler` also checks the standard library, because it needs to be checked before the compiler. This happens even with `x.py clippy --stage 0`.
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#118983 (Warn on references casting to bigger memory layout) - rust-lang#119451 (Gate PR CI on clippy correctness lints) - rust-lang#120273 (compiletest: few naive improvements) - rust-lang#120889 (Implement Instant for UEFI) - rust-lang#120938 (Implement sys/thread for UEFI) - rust-lang#120950 (Fix async closures in CTFE) - rust-lang#120958 (Dejargonize `subst`) - rust-lang#120965 (Add lahfsahf and prfchw target feature) - rust-lang#120970 (add another test for promoteds-in-static) - rust-lang#120979 (Update books) Failed merges: - rust-lang#120973 (allow static_mut_ref in some tests that specifically test mutable statics) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#118983 (Warn on references casting to bigger memory layout) - rust-lang#119451 (Gate PR CI on clippy correctness lints) - rust-lang#120273 (compiletest: few naive improvements) - rust-lang#120950 (Fix async closures in CTFE) - rust-lang#120958 (Dejargonize `subst`) - rust-lang#120965 (Add lahfsahf and prfchw target feature) - rust-lang#120970 (add another test for promoteds-in-static) - rust-lang#120979 (Update books) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#119451 - Kobzol:ci-pr-clippy, r=Mark-Simulacrum Gate PR CI on clippy correctness lints Implements part of rust-lang/compiler-team#709. Note that `x.py clippy compiler` also checks the standard library, because it needs to be checked before the compiler. This happens even with `x.py clippy --stage 0`.
Implements part of rust-lang/compiler-team#709.
Note that
x.py clippy compiler
also checks the standard library, because it needs to be checked before the compiler. This happens even withx.py clippy --stage 0
.