Skip to content

Skip threading over no-op SetDiscriminant. #119675

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2024
Merged

Skip threading over no-op SetDiscriminant. #119675

merged 1 commit into from
Jan 7, 2024

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Jan 6, 2024

Fixes #119674

@rustbot
Copy link
Collaborator

rustbot commented Jan 6, 2024

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 6, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jan 6, 2024

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@cjgillot cjgillot force-pushed the set-no-discriminant branch from ae2d429 to 41eb9a4 Compare January 7, 2024 00:28
@tmiasko
Copy link
Contributor

tmiasko commented Jan 7, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 7, 2024

📌 Commit 41eb9a4 has been approved by tmiasko

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2024
@bors
Copy link
Collaborator

bors commented Jan 7, 2024

⌛ Testing commit 41eb9a4 with merge 75c68cf...

@bors
Copy link
Collaborator

bors commented Jan 7, 2024

☀️ Test successful - checks-actions
Approved by: tmiasko
Pushing 75c68cf to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 7, 2024
@bors bors merged commit 75c68cf into rust-lang:master Jan 7, 2024
@rustbot rustbot added this to the 1.77.0 milestone Jan 7, 2024
@cjgillot cjgillot deleted the set-no-discriminant branch January 7, 2024 17:59
@bors bors mentioned this pull request Jan 7, 2024
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (75c68cf): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.2% [3.2%, 3.2%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.2% [3.2%, 3.2%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 666.132s -> 665.982s (-0.02%)
Artifact size: 308.40 MiB -> 308.42 MiB (0.00%)

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

JumpThreading is confused by an extraordinary use of SetDiscriminant
6 participants
@cjgillot @rustbot @tmiasko @bors @rust-timer @oli-obk