Skip to content

Suggest array::from_fn for array initialization #119805

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2024
Merged

Suggest array::from_fn for array initialization #119805

merged 1 commit into from
Jan 23, 2024

Conversation

chenyukang
Copy link
Member

@chenyukang chenyukang commented Jan 10, 2024 •
edited
Loading

Fixes #119530

@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2024

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 10, 2024
@rust-log-analyzer

This comment has been minimized.

# to view
@chenyukang chenyukang marked this pull request as draft January 10, 2024 11:18
davidtwco
davidtwco reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @mati865's suggestion applied

@CryZe
Copy link
Contributor

CryZe commented Jan 11, 2024

array::repeat was suggested in the issue as the more fitting alternative. Any thoughts?

@davidtwco
Copy link
Member

array::repeat was suggested in the issue as the more fitting alternative. Any thoughts?

array::repeat seems like it is just a proposal at the moment, this seems like a good suggestion in the mean time. It can always change later.

@davidtwco davidtwco changed the title Suggest arry::from_fn for array initialization Suggest array::from_fn for array initialization Jan 11, 2024
@chenyukang chenyukang force-pushed the yukang-fix-119530 branch 2 times, most recently from fe6eb6a to 5d41309 Compare January 12, 2024 15:33
@rust-log-analyzer

This comment has been minimized.

# to view
@chenyukang
Copy link
Member Author

The job x86_64-gnu-llvm-16 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

For [x; { N }], we'd better don't suggest core::array::from_fn(|_| x), since x don't met Copy trait, it will also be invalid.

I choose fn call and struct for suggesting from_fn, not 100% sure or we need much more analysis here.

@chenyukang chenyukang marked this pull request as ready for review January 12, 2024 16:21
davidtwco
davidtwco reviewed Jan 18, 2024
View reviewed changes
@davidtwco
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 23, 2024

📌 Commit 3ed96e3 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2024
fmease added a commit to fmease/rust that referenced this pull request Jan 23, 2024
@fmease
Rollup merge of rust-lang#119805 - chenyukang:yukang-fix-119530, r=da…
50552ed 
…vidtwco

Suggest array::from_fn for array initialization

Fixes rust-lang#119530
@fmease fmease mentioned this pull request Jan 23, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2024
@bors
Auto merge of rust-lang#120271 - fmease:rollup-nbm2e8h, r=fmease
8a676e9 
Rollup of 13 pull requests

Successful merges:

 - rust-lang#119028 (Add more weirdness to weird-exprs.rs)
 - rust-lang#119805 (Suggest array::from_fn for array initialization)
 - rust-lang#120124 (Split assembly tests for ELF and MachO)
 - rust-lang#120177 (Remove duplicate dependencies for rustc)
 - rust-lang#120185 (coverage: Don't instrument `#[automatically_derived]` functions)
 - rust-lang#120188 (compiler: update freebsd and netbsd base specs.)
 - rust-lang#120201 (Bump some deps with syn 1.0 dependencies)
 - rust-lang#120215 (Update some deps with `bitflags` v1 dependencies)
 - rust-lang#120244 (Use `Self` in `NonZero*` implementations.)
 - rust-lang#120246 (Re-add estebank to review rotation)
 - rust-lang#120252 (rename `RawTy` to `LoweredTy`)
 - rust-lang#120255 (correct my mailmap entry)
 - rust-lang#120270 (A bunch of random modifications)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2024
@bors
Auto merge of rust-lang#120271 - fmease:rollup-nbm2e8h, r=fmease
1f09e7d 
Rollup of 13 pull requests

Successful merges:

 - rust-lang#119028 (Add more weirdness to weird-exprs.rs)
 - rust-lang#119805 (Suggest array::from_fn for array initialization)
 - rust-lang#120124 (Split assembly tests for ELF and MachO)
 - rust-lang#120177 (Remove duplicate dependencies for rustc)
 - rust-lang#120185 (coverage: Don't instrument `#[automatically_derived]` functions)
 - rust-lang#120188 (compiler: update freebsd and netbsd base specs.)
 - rust-lang#120201 (Bump some deps with syn 1.0 dependencies)
 - rust-lang#120215 (Update some deps with `bitflags` v1 dependencies)
 - rust-lang#120244 (Use `Self` in `NonZero*` implementations.)
 - rust-lang#120246 (Re-add estebank to review rotation)
 - rust-lang#120252 (rename `RawTy` to `LoweredTy`)
 - rust-lang#120255 (correct my mailmap entry)
 - rust-lang#120270 (A bunch of random modifications)

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease fmease mentioned this pull request Jan 23, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2024
@bors
Auto merge of rust-lang#120281 - fmease:rollup-9nxail8, r=fmease
5d3d347 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#119028 (Add more weirdness to weird-exprs.rs)
 - rust-lang#119805 (Suggest array::from_fn for array initialization)
 - rust-lang#120188 (compiler: update freebsd and netbsd base specs.)
 - rust-lang#120215 (Update some deps with `bitflags` v1 dependencies)
 - rust-lang#120244 (Use `Self` in `NonZero*` implementations.)
 - rust-lang#120246 (Re-add estebank to review rotation)
 - rust-lang#120252 (rename `RawTy` to `LoweredTy`)
 - rust-lang#120255 (correct my mailmap entry)
 - rust-lang#120270 (A bunch of random modifications)
 - rust-lang#120280 (Move condition enabling the pass to `is_enabled`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dd538b5 into rust-lang:master Jan 23, 2024
@rustbot rustbot added this to the 1.77.0 milestone Jan 23, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2024
@rust-timer
Unrolled build for rust-lang#119805
f0c1c3f 
Rollup merge of rust-lang#119805 - chenyukang:yukang-fix-119530, r=davidtwco

Suggest array::from_fn for array initialization

Fixes rust-lang#119530
@est31 est31 mentioned this pull request Jan 23, 2024
Merged
fmease added a commit to fmease/rust that referenced this pull request Jan 24, 2024
@fmease
Rollup merge of rust-lang#120285 - est31:remove_extra_pound, r=fmease
4727f25 
Remove extra # from url in suggestion

The suggestion added in rust-lang#119805 contains an unnecessary # hash sign.
fmease added a commit to fmease/rust that referenced this pull request Jan 24, 2024
@fmease
Rollup merge of rust-lang#120285 - est31:remove_extra_pound, r=fmease
1c10029 
Remove extra # from url in suggestion

The suggestion added in rust-lang#119805 contains an unnecessary # hash sign.
fmease added a commit to fmease/rust that referenced this pull request Jan 24, 2024
@fmease
Rollup merge of rust-lang#120285 - est31:remove_extra_pound, r=fmease
b45eed4 
Remove extra # from url in suggestion

The suggestion added in rust-lang#119805 contains an unnecessary # hash sign.
fmease added a commit to fmease/rust that referenced this pull request Jan 24, 2024
@fmease
Rollup merge of rust-lang#120285 - est31:remove_extra_pound, r=fmease
7403d58 
Remove extra # from url in suggestion

The suggestion added in rust-lang#119805 contains an unnecessary # hash sign.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 24, 2024
@rust-timer
Unrolled build for rust-lang#120285
f010504 
Rollup merge of rust-lang#120285 - est31:remove_extra_pound, r=fmease

Remove extra # from url in suggestion

The suggestion added in rust-lang#119805 contains an unnecessary # hash sign.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mati865 mati865 mati865 left review comments

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

Suggest array::from_fn in array initialization
7 participants
@chenyukang @rustbot @rust-log-analyzer @CryZe @davidtwco @bors @mati865