Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rollup of 5 pull requests #119945

Merged
merged 12 commits into from
Jan 14, 2024
Merged

Rollup of 5 pull requests #119945

merged 12 commits into from
Jan 14, 2024

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

bvanjoi and others added 12 commits January 13, 2024 21:06
So they can remove it after they've removed the merge commit.
…ource, r=Mark-Simulacrum

Move section "Installing from Source" to seperate file

cc rust-lang#118627
store the segment name when resolution fails

Fixes rust-lang#112672

The `find_cfg_stripped` does indeed get executed within `smart_resolve_report_errors`. However, this error is not reported as it is subsequently overridden by `parent_err`. (See: https://github.com/rust-lang/rust/blob/master/compiler/rustc_resolve/src/late.rs#L3760)

This PR changes `last_segment` to `segment`, which stores the name of the failed resolution, and ensures that the result of `find_cfg_stripped` is also included in `parent_err`.

r? ```@Nilstrieb```
…isDenton

Move personality implementation out of PAL

The module already follows the new convention described in rust-lang#117276. This PR also includes a small fix in the tidy pal check, that was just an oversight in rust-lang#117285.
…rove, r=ehuss

Improve UEFI target docs

* Add a section showing exactly how to build a driver instead of an application
* Add links to the crates mentioned in the doc

CC `@dvdhrm`
…enticated, r=fmease

Allow unauthorized users to user the has-merge-commits label

So they can remove it after they've removed the merge commit.
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 13, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Jan 13, 2024

📌 Commit 847aad7 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2024
@bors
Copy link
Contributor

bors commented Jan 13, 2024

⌛ Testing commit 847aad7 with merge 3deb9bb...

@bors
Copy link
Contributor

bors commented Jan 14, 2024

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 3deb9bb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 14, 2024
@bors bors merged commit 3deb9bb into rust-lang:master Jan 14, 2024
12 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 14, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#119189 Move section "Installing from Source" to seperate file afb33a179e9f07c90f9fa7756ce08b97c525d045 (link)
#119925 store the segment name when resolution fails 5c9eca48a0f686da9345777fe06d882cf4e4a376 (link)
#119935 Move personality implementation out of PAL 7c81f0cf9c7d4345fbb7f2b1b987c8bcce26514f (link)
#119937 Improve UEFI target docs 023fb8889e510f872a5aaabdee423036cf18addc (link)
#119938 Allow unauthorized users to user the has-merge-commits label 780de877005df04e1c9ce1d1930d9a207d3798a3 (link)

previous master: d78329b92e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@bors bors mentioned this pull request Jan 14, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3deb9bb): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.6% [0.4%, 0.8%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.6% [3.4%, 3.9%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
-2.2% [-3.5%, -0.7%] 3
All ❌✅ (primary) 1.7% [-2.2%, 3.9%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.17s -> 664.704s (-0.52%)
Artifact size: 308.19 MiB -> 308.20 MiB (0.00%)

@matthiaskrgr matthiaskrgr deleted the rollup-oy3e1j2 branch March 16, 2024 18:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants