Skip to content

bootstrap: add more unit tests #120172

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2024
Merged

bootstrap: add more unit tests #120172

merged 2 commits into from
Jan 30, 2024

Conversation

onur-ozkan
Copy link
Member

self-explanatory

@rustbot
Copy link
Collaborator

rustbot commented Jan 20, 2024

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 20, 2024
Mark-Simulacrum
Mark-Simulacrum reviewed Jan 20, 2024
View reviewed changes
src/bootstrap/src/utils/change_tracker.rs Outdated
@@ -2,6 +2,10 @@
//! with the goal of keeping developers synchronized with important modifications in
//! the bootstrap.

#[cfg(test)]
#[path = "../tests/change_tracker.rs"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we doing this non-standard test movement? Just put the file in src/bootstrap/src/utils/change_tracker/test.rs -- that is the canonical way to add unit tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the current approach in other bootstrap tests, but I agree. Will update it along with others.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jan 21, 2024

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rust-log-analyzer

This comment has been minimized.

# to view
@onur-ozkan onur-ozkan added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 21, 2024
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 27, 2024

📌 Commit d315a47 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 27, 2024
@matthiaskrgr
Rollup merge of rust-lang#120172 - onur-ozkan:add-more-tests, r=Mark-…
2a97216 
…Simulacrum

bootstrap: add more unit tests

self-explanatory
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 27, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 27, 2024
@bors
Auto merge of rust-lang#120429 - matthiaskrgr:rollup-0kxx256, r=matth…
56ee58e 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#120172 (bootstrap: add more unit tests)
 - rust-lang#120266 (Improve documentation for [A]Rc::into_inner)
 - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots)
 - rust-lang#120373 (Adjust Behaviour of `read_dir` and `ReadDir` in Windows Implementation: Check Whether Path to Search In Exists)
 - rust-lang#120376 (Update codegen test for LLVM 18)
 - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis)
 - rust-lang#120425 (Remove unnecessary unit returns in query declarations)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

@bors r- rollup=iffy

failed in #120429 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 27, 2024
@onur-ozkan
add more unit tests
7668953 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
bootstrap: update test modules
d6a974d 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
Copy link
Member Author

@bors r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Jan 28, 2024

📌 Commit d6a974d has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 28, 2024
@onur-ozkan
Copy link
Member Author

@bors rollup

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 30, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 30, 2024
@bors
Auto merge of rust-lang#120491 - GuillaumeGomez:rollup-94wj681, r=Gui…
5ad7454 
…llaumeGomez

Rollup of 18 pull requests

Successful merges:

 - rust-lang#119123 (Add triagebot mentions entry for simd intrinsics)
 - rust-lang#119991 (Reject infinitely-sized reads from io::Repeat)
 - rust-lang#120172 (bootstrap: add more unit tests)
 - rust-lang#120250 (rustdoc: Prevent JS injection from localStorage)
 - rust-lang#120376 (Update codegen test for LLVM 18)
 - rust-lang#120387 (interpret/memory: fix safety comment for large array memset optimization)
 - rust-lang#120400 (Bound errors span label cleanup)
 - rust-lang#120402 (Make the coroutine def id of an async closure the child of the closure def id)
 - rust-lang#120403 (Add instructions of how to use pre-vendored 'rustc-src')
 - rust-lang#120424 (raw pointer metadata API: data address -> data pointer)
 - rust-lang#120425 (Remove unnecessary unit returns in query declarations)
 - rust-lang#120439 (Move UI issue tests to subdirectories)
 - rust-lang#120443 (Fixes footnote handling in rustdoc)
 - rust-lang#120452 (std: Update documentation of seek_write on Windows)
 - rust-lang#120460 (Be more careful about interpreting a label/lifetime as a mistyped char literal.)
 - rust-lang#120464 (Add matthewjasper to some review groups)
 - rust-lang#120467 (Update books)
 - rust-lang#120488 (Diagnostic lifetimes cleanups)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d3d621b into rust-lang:master Jan 30, 2024
@rustbot rustbot added this to the 1.77.0 milestone Jan 30, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 30, 2024
@rust-timer
Unrolled build for rust-lang#120172
5304932 
Rollup merge of rust-lang#120172 - onur-ozkan:add-more-tests, r=Mark-Simulacrum

bootstrap: add more unit tests

self-explanatory
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
6 participants
@onur-ozkan @rustbot @rust-log-analyzer @Mark-Simulacrum @bors @matthiaskrgr