Revert stabilization of trait_upcasting feature #120233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
The Miri subtree was changed cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
oli-obk
force-pushed
the
revert_trait_obj_upcast_stabilization
branch
from
c6f4347 to
7c66b07
Compare
|
The Miri subtree was changed cc @rust-lang/miri |
RalfJung
added
T-lang
This comment has been minimized.
This comment has been minimized.
|
r=me after fixing the CI failure. |
rustbot
added
S-waiting-on-author
oli-obk
force-pushed
the
revert_trait_obj_upcast_stabilization
branch
from
7c66b07 to
70172f3
Compare
This comment has been minimized.
This comment has been minimized.
oli-obk
added
beta-nominated
lcnr
approved these changes
Jan 22, 2024
oli-obk
force-pushed
the
revert_trait_obj_upcast_stabilization
branch
from
70172f3 to
483382b
Compare
|
@bors r+ p=1 |
bors
added
S-waiting-on-bors
|
This only made it to beta, right? So don't need a stable nomination? |
|
Should #65991 be reopened? |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 22, 2024
…abilization, r=lcnr Revert stabilization of trait_upcasting feature Reverts rust-lang#118133 This reverts commit 6d2b84b, reversing changes made to 73bc121. The feature has a soundness bug: * rust-lang#120222 It is unclear to me whether we'll actually want to destabilize, but I thought it was still prudent to open the PR for easy destabilization once we get there.
WaffleLapkin
removed
the
stable-nominated
|
@jackh726 I believe so |
|
@rustbot labels +I-lang-nominated Let's discuss this developing situation on the lang call. |
rustbot
added
the
I-lang-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 22, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#119664 (Fix tty detection for msys2's `/dev/ptmx`) - rust-lang#120104 (never_patterns: Count `!` bindings as diverging) - rust-lang#120109 (Move cmath into `sys`) - rust-lang#120143 (Consolidate logic around resolving built-in coroutine trait impls) - rust-lang#120159 (Track `verbose` and `verbose_internals`) - rust-lang#120188 (compiler: update freebsd and netbsd base specs.) - rust-lang#120216 (Fix a `trimmed_def_paths` assertion failure.) - rust-lang#120220 (Document `Token{Stream,Tree}::Display` more thoroughly.) - rust-lang#120233 (Revert stabilization of trait_upcasting feature) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 22, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#119664 (Fix tty detection for msys2's `/dev/ptmx`) - rust-lang#120104 (never_patterns: Count `!` bindings as diverging) - rust-lang#120109 (Move cmath into `sys`) - rust-lang#120143 (Consolidate logic around resolving built-in coroutine trait impls) - rust-lang#120159 (Track `verbose` and `verbose_internals`) - rust-lang#120216 (Fix a `trimmed_def_paths` assertion failure.) - rust-lang#120220 (Document `Token{Stream,Tree}::Display` more thoroughly.) - rust-lang#120233 (Revert stabilization of trait_upcasting feature) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 23, 2024
Rollup merge of rust-lang#120233 - oli-obk:revert_trait_obj_upcast_stabilization, r=lcnr Revert stabilization of trait_upcasting feature Reverts rust-lang#118133 This reverts commit 6d2b84b, reversing changes made to 73bc121. The feature has a soundness bug: * rust-lang#120222 It is unclear to me whether we'll actually want to destabilize, but I thought it was still prudent to open the PR for easy destabilization once we get there.
dianqk
pushed a commit
to dianqk/rust
that referenced
this pull request
Jan 23, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#119664 (Fix tty detection for msys2's `/dev/ptmx`) - rust-lang#120104 (never_patterns: Count `!` bindings as diverging) - rust-lang#120109 (Move cmath into `sys`) - rust-lang#120143 (Consolidate logic around resolving built-in coroutine trait impls) - rust-lang#120159 (Track `verbose` and `verbose_internals`) - rust-lang#120216 (Fix a `trimmed_def_paths` assertion failure.) - rust-lang#120220 (Document `Token{Stream,Tree}::Display` more thoroughly.) - rust-lang#120233 (Revert stabilization of trait_upcasting feature) r? `@ghost` `@rustbot` modify labels: rollup
|
beta backport PR opened: #120269 (not approved for beta backport yet, just opened it so we can act quickly on Thursday after the compiler team triage |
|
Giving the sentiment from T-types, I'm going to just mark this as backport approved. I don't think anyone wants to try to rush to fix this in the short time we have left until release. cc @rust-lang/types @rust-lang/lang |
jackh726
added
the
beta-accepted
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 24, 2024
…ilization, r=jackh726 [beta] Revert trait obj upcast stabilization backport of rust-lang#120233 note that this is not yet approved for beta backport
|
Agreed; since concerns came up let's revert and consider it without a rush. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 24, 2024
…ilization, r=jackh726 [beta] Revert trait obj upcast stabilization backport of rust-lang#120233 note that this is not yet approved for beta backport
rustbot
removed
the
beta-nominated
This was referenced May 30, 2024
apiraino
removed
the
I-lang-nominated
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #118133
This reverts commit 6d2b84b, reversing changes made to 73bc121.
The feature has a soundness bug:
It is unclear to me whether we'll actually want to destabilize, but I thought it was still prudent to open the PR for easy destabilization once we get there.