Skip to content

test: enable unpacked-lto tests #120264

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

weihanglo
Copy link
Member

This enables the correct unpacked-lto tests.

Not sure whether .o should be removed.
They are bitcode for linker-plugin-lto, though there might be some .o for #[no_builtins]?

@rustbot
Copy link
Collaborator

rustbot commented Jan 23, 2024

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 23, 2024
@weihanglo
Copy link
Member Author

r? michaelwoerister

I found this while addressing #118518

@rust-log-analyzer

This comment has been minimized.

@weihanglo weihanglo force-pushed the split-dward-kind-lto branch from 863b6f4 to d5811bb Compare January 23, 2024 16:05
They seems to create `.o` files, which are actually llvm bitcode.
@weihanglo weihanglo force-pushed the split-dward-kind-lto branch from d5811bb to 39e8512 Compare January 23, 2024 16:08
@weihanglo weihanglo changed the title test: verify SplitDwarfKind::Single creates .o test: enable unpacked-lto tests Jan 23, 2024
@michaelwoerister
Copy link
Member

Thanks, @weihanglo!
@bors r+ rollup=never (since this is touching a run-make test)

@bors
Copy link
Collaborator

bors commented Mar 1, 2024

📌 Commit 39e8512 has been approved by michaelwoerister

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2024
@bors
Copy link
Collaborator

bors commented Mar 1, 2024

⌛ Testing commit 39e8512 with merge 6db96de...

@bors
Copy link
Collaborator

bors commented Mar 1, 2024

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing 6db96de to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 1, 2024
@bors bors merged commit 6db96de into rust-lang:master Mar 1, 2024
@rustbot rustbot added this to the 1.78.0 milestone Mar 1, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6db96de): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
4.2% [4.2%, 4.2%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 4.2% [4.2%, 4.2%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 651.828s -> 651.67s (-0.02%)
Artifact size: 311.10 MiB -> 311.10 MiB (0.00%)

@weihanglo weihanglo deleted the split-dward-kind-lto branch March 1, 2024 19:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants