Skip to content

Expand sys/os for UEFI #120419

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2024
Merged

Expand sys/os for UEFI #120419

merged 1 commit into from
Mar 24, 2024

Conversation

Ayush1325
Copy link
Contributor

  • Implement current_exe() and getcwd()

@rustbot
Copy link
Collaborator

rustbot commented Jan 27, 2024

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 27, 2024
joboet
joboet approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@joboet joboet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Though I wonder about the interaction with the UEFI shell environment, it seems to me like we could/should make use of that, if it exists?

@Mark-Simulacrum
Copy link
Member

cc @nicholasbishop @dvdhrm (target maintainers: https://doc.rust-lang.org/nightly/rustc/platform-support/unknown-uefi.html), needs an approval per https://std-dev-guide.rust-lang.org/policy/target-code.html.

@rustbot author (mark as ready once a +1 has been given in some form from target maintainers)

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2024
@Ayush1325
Copy link
Contributor Author

cc @joshtriplett @Nilstrieb

@joshtriplett
Copy link
Member

Design seems fine and addresses the concern I had. (This is not a detailed review on the implementation.)

nicholasbishop
nicholasbishop reviewed Feb 16, 2024
View reviewed changes
nicholasbishop
nicholasbishop reviewed Mar 2, 2024
View reviewed changes
@Ayush1325
Expand sys/os for UEFI
a2497a9 
- Implement current_exe()
- Cache device_path_to_text protocol

Signed-off-by: Ayush Singh <ayushdevel1325@gmail.com>
@Ayush1325
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 21, 2024
@nicholasbishop
Copy link
Contributor

Approved by target maintainer. (I'm assuming there's no rustbot command I'm supposed to use for this and that a comment is sufficient, let me know if that's wrong.)

@workingjubilee
Copy link
Member

@bors r=nicholasbishop,workingjubilee

@bors
Copy link
Collaborator

bors commented Mar 24, 2024

📌 Commit a2497a9 has been approved by nicholasbishop,workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 24, 2024
@workingjubilee
Rollup merge of rust-lang#120419 - Ayush1325:uefi-sys-os, r=nicholasb…
101525a 
…ishop,workingjubilee

Expand sys/os for UEFI

- Implement current_exe() and getcwd()
@workingjubilee workingjubilee mentioned this pull request Mar 24, 2024
Closed
@workingjubilee workingjubilee mentioned this pull request Mar 24, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 24, 2024
@bors
Auto merge of rust-lang#122980 - workingjubilee:rollup-r5i1rke, r=wor…
4a52e9c 
…kingjubilee

Rollup of 7 pull requests

Successful merges:

 - rust-lang#120419 (Expand sys/os for UEFI)
 - rust-lang#121940 (Mention Register Size in `#[warn(asm_sub_register)]`)
 - rust-lang#122762 (fix typo of endianness)
 - rust-lang#122797 (Fix compile of wasm64-unknown-unknown target)
 - rust-lang#122875 (CFI: Support self_cell-like recursion)
 - rust-lang#122879 (CFI: Strip auto traits off Virtual calls)
 - rust-lang#122969 (Simplify an iterator search in borrowck diag)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 343c916 into rust-lang:master Mar 24, 2024
@rustbot rustbot added this to the 1.79.0 milestone Mar 24, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 24, 2024
@rust-timer
Unrolled build for rust-lang#120419
44ddd0f 
Rollup merge of rust-lang#120419 - Ayush1325:uefi-sys-os, r=nicholasbishop,workingjubilee

Expand sys/os for UEFI

- Implement current_exe() and getcwd()
@Ayush1325 Ayush1325 deleted the uefi-sys-os branch March 24, 2024 20:56
RenjiSann pushed a commit to RenjiSann/rust that referenced this pull request Mar 25, 2024
@workingjubilee @RenjiSann
Rollup merge of rust-lang#120419 - Ayush1325:uefi-sys-os, r=nicholasb…
c1579e8 
…ishop,workingjubilee

Expand sys/os for UEFI

- Implement current_exe() and getcwd()
RenjiSann pushed a commit to RenjiSann/rust that referenced this pull request Mar 25, 2024
@bors @RenjiSann
Auto merge of rust-lang#122980 - workingjubilee:rollup-r5i1rke, r=wor…
8db63b3 
…kingjubilee

Rollup of 7 pull requests

Successful merges:

 - rust-lang#120419 (Expand sys/os for UEFI)
 - rust-lang#121940 (Mention Register Size in `#[warn(asm_sub_register)]`)
 - rust-lang#122762 (fix typo of endianness)
 - rust-lang#122797 (Fix compile of wasm64-unknown-unknown target)
 - rust-lang#122875 (CFI: Support self_cell-like recursion)
 - rust-lang#122879 (CFI: Strip auto traits off Virtual calls)
 - rust-lang#122969 (Simplify an iterator search in borrowck diag)

r? `@ghost`
`@rustbot` modify labels: rollup
@Ayush1325 Ayush1325 mentioned this pull request Jul 6, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@joboet joboet joboet approved these changes

@joshtriplett joshtriplett Awaiting requested review from joshtriplett

+1 more reviewer

@nicholasbishop nicholasbishop nicholasbishop approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Ayush1325 @rustbot @Mark-Simulacrum @joshtriplett @nicholasbishop @workingjubilee @bors @joboet