Skip to content

hir: Two preparatory changes for #120206 #120428

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2024
Merged

hir: Two preparatory changes for #120206 #120428

merged 2 commits into from
Jan 29, 2024

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Jan 27, 2024 •
edited
Loading

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 27, 2024
@petrochenkov petrochenkov mentioned this pull request Jan 27, 2024
Merged
@rust-log-analyzer

This comment has been minimized.

# to view
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 27, 2024

📌 Commit 06c1da2 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2024
cjgillot
cjgillot reviewed Jan 27, 2024
View reviewed changes
@cjgillot
Copy link
Contributor

CI failure.
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 27, 2024
@compiler-errors
Copy link
Member

Whoops. Thanks for catching that.

@petrochenkov
hir: Remove unnecessary HirId from hir::Let
5f8030d 
It has 1-to-1 correspondence to its expression id.

Also remove mostly useless `visit_let_expr`.
@petrochenkov
hir: Use InferArg in ArrayLen::Infer
b2b5b91
@petrochenkov
Copy link
Contributor Author

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Jan 27, 2024

📌 Commit b2b5b91 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 27, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 28, 2024
@matthiaskrgr
Rollup merge of rust-lang#120428 - petrochenkov:somehir2, r=compiler-…
4a759f0 
…errors

hir: Two preparatory changes for rust-lang#120206

cc rust-lang#120206
r? `@compiler-errors`
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 28, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2024
@bors
Auto merge of rust-lang#120437 - matthiaskrgr:rollup-h1uai71, r=matth…
a162071 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots)
 - rust-lang#120402 (Make the coroutine def id of an async closure the child of the closure def id)
 - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis)
 - rust-lang#120425 (Remove unnecessary unit returns in query declarations)
 - rust-lang#120428 (hir: Two preparatory changes for rust-lang#120206)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2024
@bors
Auto merge of rust-lang#120437 - matthiaskrgr:rollup-h1uai71, r=matth…
769e1fe 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots)
 - rust-lang#120402 (Make the coroutine def id of an async closure the child of the closure def id)
 - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis)
 - rust-lang#120425 (Remove unnecessary unit returns in query declarations)
 - rust-lang#120428 (hir: Two preparatory changes for rust-lang#120206)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2024
@bors
Auto merge of rust-lang#120437 - matthiaskrgr:rollup-h1uai71, r=matth…
8d9b7de 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots)
 - rust-lang#120402 (Make the coroutine def id of an async closure the child of the closure def id)
 - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis)
 - rust-lang#120425 (Remove unnecessary unit returns in query declarations)
 - rust-lang#120428 (hir: Two preparatory changes for rust-lang#120206)

r? `@ghost`
`@rustbot` modify labels: rollup
fmease added a commit to fmease/rust that referenced this pull request Jan 29, 2024
@fmease
Rollup merge of rust-lang#120428 - petrochenkov:somehir2, r=compiler-…
e7824d5 
…errors

hir: Two preparatory changes for rust-lang#120206

cc rust-lang#120206
r? ``@compiler-errors``
@fmease fmease mentioned this pull request Jan 29, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2024
@bors
Auto merge of rust-lang#120461 - fmease:rollup-30y3cyy, r=fmease
9b7e09b 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#116677 (References refer to allocated objects)
 - rust-lang#119991 (Reject infinitely-sized reads from io::Repeat)
 - rust-lang#120266 (Improve documentation for [A]Rc::into_inner)
 - rust-lang#120376 (Update codegen test for LLVM 18)
 - rust-lang#120402 (Make the coroutine def id of an async closure the child of the closure def id)
 - rust-lang#120424 (raw pointer metadata API: data address -> data pointer)
 - rust-lang#120425 (Remove unnecessary unit returns in query declarations)
 - rust-lang#120428 (hir: Two preparatory changes for rust-lang#120206)
 - rust-lang#120434 (Revert outdated version of "Add the wasm32-wasi-preview2 target")
 - rust-lang#120443 (Fixes footnote handling in rustdoc)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2024
@bors
Auto merge of rust-lang#120437 - matthiaskrgr:rollup-h1uai71, r=matth…
abbba77 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots)
 - rust-lang#120402 (Make the coroutine def id of an async closure the child of the closure def id)
 - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis)
 - rust-lang#120425 (Remove unnecessary unit returns in query declarations)
 - rust-lang#120428 (hir: Two preparatory changes for rust-lang#120206)

r? `@ghost`
`@rustbot` modify labels: rollup
@Dylan-DPC Dylan-DPC mentioned this pull request Jan 29, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2024
@bors
Auto merge of rust-lang#120466 - Dylan-DPC:rollup-v0or19a, r=Dylan-DPC
9ee33fb 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#116677 (References refer to allocated objects)
 - rust-lang#118625 (Improve handling of expressions in patterns)
 - rust-lang#120266 (Improve documentation for [A]Rc::into_inner)
 - rust-lang#120373 (Adjust Behaviour of `read_dir` and `ReadDir` in Windows Implementation: Check Whether Path to Search In Exists)
 - rust-lang#120390 (Borrow check inline const patterns)
 - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis)
 - rust-lang#120428 (hir: Two preparatory changes for rust-lang#120206)
 - rust-lang#120453 (Fix incorrect comment in normalize_newlines)
 - rust-lang#120462 (Clean dead code)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2024
@bors
Auto merge of rust-lang#120466 - Dylan-DPC:rollup-v0or19a, r=Dylan-DPC
5518eaa 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#116677 (References refer to allocated objects)
 - rust-lang#118625 (Improve handling of expressions in patterns)
 - rust-lang#120266 (Improve documentation for [A]Rc::into_inner)
 - rust-lang#120373 (Adjust Behaviour of `read_dir` and `ReadDir` in Windows Implementation: Check Whether Path to Search In Exists)
 - rust-lang#120390 (Borrow check inline const patterns)
 - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis)
 - rust-lang#120428 (hir: Two preparatory changes for rust-lang#120206)
 - rust-lang#120453 (Fix incorrect comment in normalize_newlines)
 - rust-lang#120462 (Clean dead code)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit eaa1002 into rust-lang:master Jan 29, 2024
@rustbot rustbot added this to the 1.77.0 milestone Jan 29, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2024
@rust-timer
Unrolled build for rust-lang#120428
b01cda7 
Rollup merge of rust-lang#120428 - petrochenkov:somehir2, r=compiler-errors

hir: Two preparatory changes for rust-lang#120206

cc rust-lang#120206
r? ```@compiler-errors```
@petrochenkov petrochenkov deleted the somehir2 branch February 22, 2025 18:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cjgillot cjgillot cjgillot left review comments

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
6 participants
@petrochenkov @rust-log-analyzer @compiler-errors @bors @cjgillot @rustbot