Improve error message when cargo build is used to build the compiler
#120475
Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Thanks for the PR, @Nilstrieb! Have you verified that this doesn't break rust-analyzer or build-std? |
|
It's in the compiler, so it can't break build-std. ra doesn't use rust/compiler/rustc_abi/Cargo.toml Line 13 in c401f09 If ra wanted to start using it in the future, we'd have to the script, which sounds fine. |
Sorry, I got confused while reading #76446 and thought this PR was about the standard library too 🤦
My question was more about whether ra will still work for people who are working on the compiler. If one goes through this setup it should be fine. But I don't know how many people know about that. |
|
OK, it looks like ra doesn't work very well without this setup to begin with. Let's merge this and see if it causes unforeseen trouble. @bors r+ |
bors
added
S-waiting-on-bors
…llaumeGomez Rollup of 11 pull requests Successful merges: - rust-lang#117906 (Improve display of crate name when hovered) - rust-lang#118533 (Suppress unhelpful diagnostics for unresolved top level attributes) - rust-lang#120293 (Deduplicate more sized errors on call exprs) - rust-lang#120295 (Remove `raw_os_nonzero` feature.) - rust-lang#120310 (adapt test for v0 symbol mangling) - rust-lang#120342 (Remove various `has_errors` or `err_count` uses) - rust-lang#120434 (Revert outdated version of "Add the wasm32-wasi-preview2 target") - rust-lang#120445 (Fix some `Arc` allocator leaks) - rust-lang#120475 (Improve error message when `cargo build` is used to build the compiler) - rust-lang#120476 (Remove some unnecessary check logic for lang items in HIR typeck) - rust-lang#120485 (add missing potential_query_instability for keys and values in hashmap) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#120475 - Nilstrieb:cargo-build-my-a-, r=michaelwoerister Improve error message when `cargo build` is used to build the compiler Inspired by rust-lang#76446. Doing it for `core` is probably higher value but also way harder because tools like cargo or rustc-build-sysroot would need to be fixed first, which I don't feel like doing.
Inspired by #76446.
Doing it for
coreis probably higher value but also way harder because tools like cargo or rustc-build-sysroot would need to be fixed first, which I don't feel like doing.